Simplify generated code for trivial bailout methods.

lib/compiler/implementation/ssa/bailout.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class BailoutInfo {
   int instructionId;
   int bailoutId;
   BailoutInfo(this.instructionId, this.bailoutId);
 }
 
 /**
  * Keeps track of the execution environment for instructions. An
  * execution environment contains the SSA instructions that are live.
  */
 class Environment {
   final Set<HInstruction> lives;
   final Set<HBasicBlock> loopMarkers;
   Environment() : lives = new Set<HInstruction>(),
                   loopMarkers = new Set<HBasicBlock>();
   Environment.from(Environment other)
     : lives = new Set<HInstruction>.from(other.lives),
       loopMarkers = new Set<HBasicBlock>.from(other.loopMarkers);
 
   void remove(HInstruction instruction) {
     lives.remove(instruction);
   }
 
   void add(HInstruction instruction) {
-    if (!instruction.isCodeMotionInvariant()) {
+    // We don't need to an code motion invariant instructions in the

[kasperl, 2012/06/12 12:18:40]

need to an code?

[ngeoffray, 2012/06/12 12:28:18]

Done.

+    // live set except for parameters that are not 'this' ('this' is

[kasperl, 2012/06/12 12:18:40]

('this' is -> , which is 

[ngeoffray, 2012/06/12 12:28:18]

Done.

+    // always passed as the receiver).
+    if (!instruction.isCodeMotionInvariant()

[floitsch, 2012/06/12 15:01:17]

Explain that this is, because we generate these at use-site.
Any possibility to ensure this (like asserts)?

+        || (instruction is HParameterValue && instruction is !HThis)) {
       lives.add(instruction);
     } else {
       for (int i = 0, len = instruction.inputs.length; i < len; i++) {
         add(instruction.inputs[i]);
       }
     }
   }
 
   void addLoopMarker(HBasicBlock block) {
     loopMarkers.add(block);
@@ skipping 152 matching lines @@
     if (speculativeType == computedType) return false;
     // If a bailout check is more expensive than doing the actual operation
     // don't do it either.
     return typeGuardWouldBeValuable(instruction, speculativeType);
   }
 
   void visitInstruction(HInstruction instruction) {
     HType speculativeType = instruction.propagatedType;
     if (shouldInsertTypeGuard(instruction)) {
       List<HInstruction> inputs = <HInstruction>[instruction];
-      HTypeGuard guard = new HTypeGuard(speculativeType, stateId++, inputs);
+      HInstruction insertionPoint;
+      if (instruction is HPhi) {
+        insertionPoint = instruction.block.first;
+      } else if (instruction is HParameterValue) {
+        // We insert the type guard at the end of the entry block
+        // because if a parameter is live, it must be kept in the live
+        // environment. Not doing so would mean we could visit a
+        // parameter and remove it from the environment before
+        // visiting a type guard.
+        insertionPoint = instruction.block.last;
+      } else {
+        insertionPoint = instruction.next;
+      }
+      int state;

[kasperl, 2012/06/12 12:18:40]

I would move 'int state' down below the comment.

[ngeoffray, 2012/06/12 12:28:18]

Done.

+      // If the previous instruction is also a type guard, then both
+      // guards have the same environment, and can therefore share the
+      // same state id.
+      if (insertionPoint.previous is HTypeGuard) {
+        HTypeGuard other = insertionPoint.previous;
+        state = other.state;
+      } else {
+        state = stateId++;
+      }
+      HTypeGuard guard = new HTypeGuard(speculativeType, state, inputs);
       guard.propagatedType = speculativeType;
       work.guards.add(guard);
       instruction.block.rewrite(instruction, guard);
-      HInstruction insertionPoint = (instruction is HPhi)
-          ? instruction.block.first
-          : instruction.next;
       insertionPoint.block.addBefore(insertionPoint, guard);
     }
   }
 }
 
 /**
  * Computes the environment for each SSA instruction: visits the graph
  * in post-dominator order. Removes an instruction from the environment
  * and adds its inputs to the environment at the instruction's
  * definition.
@@ skipping 114 matching lines @@
 
 /**
  * Propagates bailout information to blocks that need it. This visitor
  * is run before codegen, to know which blocks have to deal with
  * bailouts.
  */
 class SsaBailoutPropagator extends HBaseVisitor {
   final Compiler compiler;
   final List<HBasicBlock> blocks;
   final List<HLabeledBlockInformation> labeledBlockInformations;
+  final Set<HInstruction> generateAtUseSite;
+  final VariableNames variableNames;
   SubGraph subGraph;
 
-  SsaBailoutPropagator(Compiler this.compiler)
+  /**
+   * If set to true, the graph has either multiple bailouts in
+   * different places, or a bailout inside an if or a loop. For such a
+   * graph, the code generator will emit a generic switch.
+   */
+  bool hasComplexTypeGuards = false;
+
+  /**
+   * The first type guard in the graph.
+   */
+  HTypeGuard firstTypeGuard;
+
+  /**
+   * If set, it is the first block in the graph where we generate
+   * code. Blocks before this one are dead code in the bailout
+   * version.
+   */
+  HBasicBlock startGeneratingAt;
+

[kasperl, 2012/06/12 12:18:40]

Remove one newline here.

[ngeoffray, 2012/06/12 12:28:18]

Done.

+
+  SsaBailoutPropagator(this.compiler,
+                       this.generateAtUseSite,
+                       this.variableNames)
       : blocks = <HBasicBlock>[],
         labeledBlockInformations = <HLabeledBlockInformation>[];
 
   void visitGraph(HGraph graph) {
     subGraph = new SubGraph(graph.entry, graph.exit);
-    blocks.addLast(graph.entry);
     visitBasicBlock(graph.entry);
-    blocks.removeLast();
     if (!blocks.isEmpty()) {
       compiler.internalError('Bailout propagation',
           node: compiler.currentElement.parseNode(compiler));
     }
   }
 
   void visitBasicBlock(HBasicBlock block) {
     // Abort traversal if we are leaving the currently active sub-graph.
     if (!subGraph.contains(block)) return;
 
     if (block.isLoopHeader()) {
       blocks.addLast(block);
-    } else if (block.isLabeledBlock() && blocks.last() !== block) {
+    } else if (block.isLabeledBlock()
+               && (blocks.isEmpty() || blocks.last() !== block)) {
       HLabeledBlockInformation info = block.blockFlow.body;
       visitStatements(info.body);
       return;
     }
 
     HInstruction instruction = block.first;
     while (instruction != null) {
       instruction.accept(this);
       instruction = instruction.next;
     }
@@ skipping 76 matching lines @@
 
     visitBasicBlock(branchBlock.successors[1]);
     // With labeled breaks we can have more dominated blocks.
     if (dominated.length >= 3) {
       for (int i = 2; i < dominated.length; i++) {
         visitBasicBlock(dominated[i]);
       }
     }
   }
 
+  // If argument is a [HCheck] and it does not have a name, we try to
+  // find the name of its checked input. Note that there must be a
+  // name, otherwise the instruction would not be in the live
+  // environment.
+  HInstruction unwrap(argument) {       
+    while (argument is HCheck && !variableNames.hasName(argument)) {
+      argument = argument.checkedInput;
+    }
+    assert(variableNames.hasName(argument));
+    return argument;    
+  }
+
   visitTypeGuard(HTypeGuard guard) {
-    blocks.forEach((HBasicBlock block) {
-      block.guards.add(guard);
-    });
+    // Sort the names of all type guards, to be able to merge

[kasperl, 2012/06/12 12:18:40]

to be able to -> so we can

[ngeoffray, 2012/06/12 12:28:18]

Done.

+    // guards that have the same state id.
+    List<String> names = <String>[];
+    for (HInstruction input in guard.inputs) {
+      HInstruction instruction = unwrap(input);
+      names.add(variableNames.getName(instruction));
+    }
+    names.sort((a, b) => a.compareTo(b));
+    guard.sortedVariableNames = names;
+
+    if (firstTypeGuard === null || firstTypeGuard.state === guard.state) {
+      firstTypeGuard = guard;
+      if (!blocks.isEmpty()) {
+        hasComplexTypeGuards = true;
+        // We start generating at the first block that has control
+        // flow.
+        startGeneratingAt = blocks[0];
+        blocks.forEach((HBasicBlock block) {
+          block.guards.add(guard);
+        });
+      }
+    } else {
+      hasComplexTypeGuards = true;
+      blocks.forEach((HBasicBlock block) {
+        block.guards.add(guard);
+      });
+    }
   }
 }