Issue 10539087: Re-enable some aura_shell_unittests for asan failure has been resolved in app list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539087: Re-enable some aura_shell_unittests for asan failure has been resolved in app list. (Closed)

Created:
8 years, 6 months ago by jennyz

Modified:
8 years, 6 months ago

Reviewers:
xiyuan, sadrul, sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-enable a couple of aura_shell_unittests cases for the asan failure has been fixed in app list code. It looks like heap issue should have been fixed by xiyuan's cl: http://crrev.com/136506 Since they have the same stack. BUG=127538 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141498

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	ash/system/tray/system_tray_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	ash/wm/shelf_layout_manager_unittest.cc	View	1	3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 7 (0 generated)

jennyz

Sorry, I overlooked some other tests failed for the same stack. Adding them in patch ...

8 years, 6 months ago (2012-06-11 18:09:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10539087/4001

8 years, 6 months ago (2012-06-11 19:53:00 UTC) #6

Change committed as 141498