Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10539082: Add DSC files for the various examples. (Closed)

Created:
8 years, 6 months ago by noelallen1
Modified:
8 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add DSC files for the various examples. These will replace the current method for copying projects over and defining their makefiles. The makefiles will be removed in a different CL to atomically switch between the two versions. BUG=130618 R=binji@chromium.org TEST=test_generate_make.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141601

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -152 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 1 2 3 4 4 chunks +103 lines, -30 lines 0 comments Download
M native_client_sdk/src/build_tools/template.mk View 1 2 3 6 chunks +35 lines, -40 lines 0 comments Download
M native_client_sdk/src/examples/debugging/debugging.html View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/dlopen/dlopen.html View 1 2 3 4 1 chunk +101 lines, -47 lines 0 comments Download
M native_client_sdk/src/examples/file_io/example.dsc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_io/file_io.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/file_io/file_io.html View 1 2 3 4 1 chunk +29 lines, -17 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_newlib/hello_world.c View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_newlib/hello_world.html View 1 2 3 4 4 chunks +37 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
lgtm http://codereview.chromium.org/10539082/diff/12/native_client_sdk/src/build_tools/generate_make.py File native_client_sdk/src/build_tools/generate_make.py (right): http://codereview.chromium.org/10539082/diff/12/native_client_sdk/src/build_tools/generate_make.py#newcode49 native_client_sdk/src/build_tools/generate_make.py:49: if not line: is this if needed anymore? ...
8 years, 6 months ago (2012-06-11 20:22:29 UTC) #1
noelallen1
http://codereview.chromium.org/10539082/diff/12/native_client_sdk/src/build_tools/generate_make.py File native_client_sdk/src/build_tools/generate_make.py (right): http://codereview.chromium.org/10539082/diff/12/native_client_sdk/src/build_tools/generate_make.py#newcode49 native_client_sdk/src/build_tools/generate_make.py:49: if not line: On 2012/06/11 20:22:29, binji wrote: > ...
8 years, 6 months ago (2012-06-11 20:34:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10539082/11001
8 years, 6 months ago (2012-06-11 21:56:30 UTC) #3
commit-bot: I haz the power
Try job failure for 10539082-11001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-11 23:46:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10539082/11001
8 years, 6 months ago (2012-06-12 00:26:08 UTC) #5
commit-bot: I haz the power
Change committed as 141601
8 years, 6 months ago (2012-06-12 02:44:01 UTC) #6
noelallen1
8 years, 6 months ago (2012-06-13 00:12:32 UTC) #7

          

Powered by Google App Engine
This is Rietveld 408576698