Issue 10539060: Make platform app context menu browser tests more resilient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539060: Make platform app context menu browser tests more resilient. (Closed)

Created:
8 years, 6 months ago by benwells

Modified:
8 years, 6 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make platform app context menu browser tests more resilient. Instead of magic numbers for the correct total item count in menus, check for the existence and absence of the items we do and don't want. BUG=None TEST=Covered by existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141179

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	chrome/browser/extensions/platform_app_browsertest.cc	View		4 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10539060/1

8 years, 6 months ago (2012-06-08 04:39:39 UTC) #3

Change committed as 141179

Expand Messages | Collapse Messages