Improve errors for the bluetooth.connect API

chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/bluetooth/bluetooth_api.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/experimental_bluetooth.h"
@@ skipping 25 matching lines @@
 
 chromeos::BluetoothAdapter* GetMutableAdapter(Profile* profile) {
   return GetEventRouter(profile)->GetMutableAdapter();
 }
 
 }  // namespace
 #endif
 
 namespace {
 
+const char kFailedToConnect[] = "Connection failed";
+const char kInvalidDevice[] = "Invalid device";
 const char kSocketNotFoundError[] = "Socket not found: invalid socket id";
 
 }  // namespace
 
 namespace Connect = extensions::api::experimental_bluetooth::Connect;
 namespace Disconnect = extensions::api::experimental_bluetooth::Disconnect;
 namespace GetDevicesWithServiceName =
     extensions::api::experimental_bluetooth::GetDevicesWithServiceName;
 namespace GetDevicesWithServiceUUID =
     extensions::api::experimental_bluetooth::GetDevicesWithServiceUUID;
@@ skipping 102 matching lines @@
     int socket_id = GetEventRouter(profile())->RegisterSocket(socket);
 
     experimental_bluetooth::Socket result_socket;
     result_socket.device.address = device->address();
     result_socket.device.name = UTF16ToUTF8(device->GetName());
     result_socket.service_uuid = service_uuid;
     result_socket.id = socket_id;
     result_.reset(result_socket.ToValue().release());
     SendResponse(true);
   } else {
+    SetError(kFailedToConnect);
     SendResponse(false);
   }
 
   Release();  // Added in RunImpl
 }
 
 bool BluetoothConnectFunction::RunImpl() {
   scoped_ptr<Connect::Params> params(Connect::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get() != NULL);
 
   chromeos::BluetoothDevice* device =
       GetMutableAdapter(profile())->GetDevice(params->device.address);
   if (!device) {
     SendResponse(false);
+    SetError(kInvalidDevice);
     return false;
   }
 
   AddRef();
   device->ConnectToService(params->service,
       base::Bind(&BluetoothConnectFunction::ConnectToServiceCallback,
                  this,
                  device,
                  params->service));
   return true;
@@ skipping 183 matching lines @@
   return false;
 }
 
 bool BluetoothGetOutOfBandPairingDataFunction::RunImpl() {
   NOTREACHED() << "Not implemented yet";
   return false;
 }
 
 }  // namespace api
 }  // namespace extensions