Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10539028: Only paste the fragment of text which was copied to the clipboard. (Closed)

Created:
8 years, 6 months ago by raymes
Modified:
8 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dcheng, tony
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Only paste the fragment of text which was copied to the clipboard. This also changes how clipboard data is copied on windows. Previously we would copy: "<html>\r\n<body>\r\n<!--StartFragment-->\r\n[CONTENT]\r\n<!--EndFragment-->\r\n</body>\r\n</html>" However, when pasting this content, we paste everything that's contained between <!--StartFragment--> and <!--EndFragment-->. Thus, we get additional new lines in our pasted content that did not exist in the copied content. AFAICT there is no reason to add this additional newlines when copying clipboard data. BUG=130827 TEST=Ran updated test case. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144932

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M ppapi/tests/test_flash_clipboard.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
raymes
yzshen for pepper side dcheng for clipboard
8 years, 5 months ago (2012-06-28 00:10:39 UTC) #1
dcheng
Can you add me to the CC for the associated bug? I can't view it ...
8 years, 5 months ago (2012-06-28 00:18:20 UTC) #2
raymes
On 2012/06/28 00:18:20, dcheng wrote: > Can you add me to the CC for the ...
8 years, 5 months ago (2012-06-28 16:11:05 UTC) #3
yzshen1
Hi, Raymes. Please send future CLs to my @chromium.org account, otherwise I cannot easily see ...
8 years, 5 months ago (2012-06-28 19:14:49 UTC) #4
raymes
Oh...sorry, I just typed your username and I guess it auto-completes to your google address ...
8 years, 5 months ago (2012-06-28 19:21:07 UTC) #5
yzshen1
pepper part LGTM
8 years, 5 months ago (2012-06-28 19:24:43 UTC) #6
dcheng
LGTM. Some notes though: Excel wraps copied blocks in newlines; Word does not, so it ...
8 years, 5 months ago (2012-06-28 21:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10539028/17001
8 years, 5 months ago (2012-06-28 21:57:06 UTC) #8
commit-bot: I haz the power
Presubmit check for 10539028-17001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-06-28 21:57:09 UTC) #9
raymes
+ben for OWNERS approval of ui/base/dragdrop/os_exchange_data_win_unittest.cc
8 years, 5 months ago (2012-06-28 22:00:26 UTC) #10
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-06-29 16:02:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10539028/17001
8 years, 5 months ago (2012-06-29 16:03:20 UTC) #12
commit-bot: I haz the power
Try job failure for 10539028-17001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-06-29 16:53:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10539028/17001
8 years, 5 months ago (2012-06-29 17:05:21 UTC) #14
commit-bot: I haz the power
8 years, 5 months ago (2012-06-29 18:14:36 UTC) #15
Change committed as 144932

Powered by Google App Engine
This is Rietveld 408576698