Issue 10539007: NetworkSmsHandler: Use the ModemManager1 dbus interfaces

Issue 10539007: NetworkSmsHandler: Use the ModemManager1 dbus interfaces (Closed)

Created:
8 years, 6 months ago by Jason Glasgow

Modified:
8 years, 6 months ago

Reviewers:
stevenjb (google-dont-use), stevenjb, hashimoto, Ben Chan

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium/src@master

Visibility:
Public.

More Reviews

Description

NetworkSmsHandler: Use the ModemManager1 dbus interfaces Adapt NetworkSmsHandler to monitor both the ModemManager and ModemManager1 dbus interfaces for SMS messages. BUG=chromium-os:28421 TEST=chromeos_unittests Change-Id: Ifbbce68192a360240f519608d4bea46c30997493 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141732

Patch Set 1 #

Patch Set 2 : Implement full unit testing #

Patch Set 3 : Remove dependency on RequestUpdate for ModemMessagingClient #

Patch Set 4 : Only deliver messages after call to RequestUpdate #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+251 lines, -30 lines)			Patch
M	chromeos/network/network_sms_handler.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chromeos/network/network_sms_handler.cc	View	1 2	12 chunks	+214 lines, -23 lines	0 comments	Download
M	chromeos/network/network_sms_handler_unittest.cc	View	1 2 3	3 chunks	+33 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

ptal -- I enhanced the unit tests so that it tests the ModemManager1 interfaces as ...

8 years, 6 months ago (2012-06-08 19:51:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jglasgow@chromium.org/10539007/6002

8 years, 6 months ago (2012-06-12 19:19:04 UTC) #6

Change committed as 141732

Expand Messages | Collapse Messages