Issue 10538098: Disable Shift+Alt while KeyboardOverlayDialogView is shown.

LGTM http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc File chrome/browser/ui/views/keyboard_overlay_dialog_view.cc (right): http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc#newcode43 chrome/browser/ui/views/keyboard_overlay_dialog_view.cc:43: #if defined(OS_CHROMEOS) Add a comment here and in ...

8 years, 6 months ago (2012-06-12 04:23:24 UTC) #2

Yusuke Sato

http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc File chrome/browser/ui/views/keyboard_overlay_dialog_view.cc (right): http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc#newcode43 chrome/browser/ui/views/keyboard_overlay_dialog_view.cc:43: #if defined(OS_CHROMEOS) On 2012/06/12 04:23:24, sky wrote: > Add ...

8 years, 6 months ago (2012-06-12 05:12:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10538098/6001

8 years, 6 months ago (2012-06-12 05:13:23 UTC) #4

Change committed as 141628

Expand Messages | Collapse Messages

Issue 10538098: Disable Shift+Alt while KeyboardOverlayDialogView is shown. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comment #

Messages