Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 10538098: Disable Shift+Alt while KeyboardOverlayDialogView is shown. (Closed)

Created:
8 years, 6 months ago by Yusuke Sato
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Disable Shift+Alt while KeyboardOverlayDialogView is shown. BUG=131159 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141628

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuke Sato
8 years, 6 months ago (2012-06-12 01:47:13 UTC) #1
sky
LGTM http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc File chrome/browser/ui/views/keyboard_overlay_dialog_view.cc (right): http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc#newcode43 chrome/browser/ui/views/keyboard_overlay_dialog_view.cc:43: #if defined(OS_CHROMEOS) Add a comment here and in ...
8 years, 6 months ago (2012-06-12 04:23:24 UTC) #2
Yusuke Sato
http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc File chrome/browser/ui/views/keyboard_overlay_dialog_view.cc (right): http://codereview.chromium.org/10538098/diff/1/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc#newcode43 chrome/browser/ui/views/keyboard_overlay_dialog_view.cc:43: #if defined(OS_CHROMEOS) On 2012/06/12 04:23:24, sky wrote: > Add ...
8 years, 6 months ago (2012-06-12 05:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10538098/6001
8 years, 6 months ago (2012-06-12 05:13:23 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 08:34:28 UTC) #5
Change committed as 141628

Powered by Google App Engine
This is Rietveld 408576698