Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10538083: Coverity: Initialize member variables. (Closed)

Created:
8 years, 6 months ago by James Hawkins
Modified:
8 years, 6 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Coverity: Initialize member variables. CID_COUNT=4 CID=104190,104193,104197,104204 BUG=none TEST=none R=groby TBR=rdsmith,vrk,tommi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/download/download_file_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/h264_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/async_socket_io_handler_posix.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/media/buffered_data_source.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
8 years, 6 months ago (2012-06-11 14:56:45 UTC) #1
tommi (sloooow) - chröme
Lgtm On Jun 11, 2012 4:56 PM, <jhawkins@chromium.org> wrote: > Reviewers: groby, rdsmith, vrk, tommi, ...
8 years, 6 months ago (2012-06-11 15:40:37 UTC) #2
groby-ooo-7-16
lgtm
8 years, 6 months ago (2012-06-12 12:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10538083/1
8 years, 6 months ago (2012-06-12 12:10:16 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 12:10:17 UTC) #5
Failed to apply patch for webkit/media/buffered_data_source.cc:
While running patch -p1 --forward --force;
patching file webkit/media/buffered_data_source.cc
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file
webkit/media/buffered_data_source.cc.rej

Powered by Google App Engine
This is Rietveld 408576698