Remove duplicate call to InitAndroidTest.

Remove duplicate call to InitAndroidTest.

The method is called from test_suite.cc.
Also moving methods in test_support_android inside a namespace.

BUG=125059
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141473

[Xianzhu, 2012-06-08 19:35:37]

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
File base/test/test_support_android.h (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
base/test/test_support_android.h:8: namespace base {
Shall we also add 'namespace android'?
I saw other header files in base/android using base::android:: namespace.

https://chromiumcodereview.appspot.com/10538065/diff/1/webkit/support/platfor...
File webkit/support/platform_support_android.cc (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/webkit/support/platfor...
webkit/support/platform_support_android.cc:36: base::InitAndroidTestPaths();
Nit: Extra indent

[nilesh, 2012-06-08 19:39:12]

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
File base/test/test_support_android.h (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
base/test/test_support_android.h:8: namespace base {
On 2012/06/08 19:35:37, Xianzhu wrote:
> Shall we also add 'namespace android'?
> I saw other header files in base/android using base::android:: namespace.

Yeah, but this is in base/test/.
Other files in base/test/ use namespace base.

https://chromiumcodereview.appspot.com/10538065/diff/1/webkit/support/platfor...
File webkit/support/platform_support_android.cc (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/webkit/support/platfor...
webkit/support/platform_support_android.cc:36: base::InitAndroidTestPaths();
On 2012/06/08 19:35:37, Xianzhu wrote:
> Nit: Extra indent

Done.

[Xianzhu, 2012-06-08 19:44:52]

lgtm, but I'm not an owner.

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
File base/test/test_support_android.h (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
base/test/test_support_android.h:8: namespace base {
On 2012/06/08 19:39:12, nileshagrawal1 wrote:
> On 2012/06/08 19:35:37, Xianzhu wrote:
> > Shall we also add 'namespace android'?
> > I saw other header files in base/android using base::android:: namespace.
> 
> Yeah, but this is in base/test/.
> Other files in base/test/ use namespace base.

Sorry, my fault :)

[nilesh, 2012-06-08 19:54:34]

Hi Kent, Please take a look at webkit/support

[John Grabowski, 2012-06-08 20:52:26]

LGTM

[nilesh, 2012-06-08 21:12:51]

@mark: Please look at base/

[Mark Mentovai, 2012-06-09 02:11:34]

LGTM for base OWNERS approval.

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
File base/test/test_support_android.cc (right):

https://chromiumcodereview.appspot.com/10538065/diff/1/base/test/test_support...
base/test/test_support_android.cc:203: } // namespace base
Style nit: two spaces between the } and the //.

[tkent, 2012-06-11 01:15:54]

LGTM for webkit/support/

[nilesh, 2012-06-11 17:45:27]

http://codereview.chromium.org/10538065/diff/1/base/test/test_support_android.cc
File base/test/test_support_android.cc (right):

http://codereview.chromium.org/10538065/diff/1/base/test/test_support_android...
base/test/test_support_android.cc:203: } // namespace base
On 2012/06/09 02:11:34, Mark Mentovai wrote:
> Style nit: two spaces between the } and the //.

Done.

[commit-bot: I haz the power, 2012-06-11 17:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10538065/4003

[commit-bot: I haz the power, 2012-06-11 19:56:08]

Change committed as 141473