Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10538064: Implement inlined LoadIndexed operation for arrays on x64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/intermediate_language.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 6a767238cfa8e3a0338e915a0b4a9e5d45ae8c2d..d99e1b9c0cef4beb574a30b4b23818d0034e7d9e 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1951,15 +1951,13 @@ void EffectGraphVisitor::VisitLoadIndexedNode(LoadIndexedNode* node) {
ValueGraphVisitor for_index(owner(), for_array.temp_index());
node->index_expr()->Visit(&for_index);
Append(for_index);
- ZoneGrowableArray<Value*>* arguments = new ZoneGrowableArray<Value*>(2);
- arguments->Add(for_array.value());
- arguments->Add(for_index.value());
- const String& name =
- String::ZoneHandle(String::NewSymbol(Token::Str(Token::kINDEX)));
- InstanceCallComp* call = new InstanceCallComp(
- node->token_index(), owner()->try_index(), name,
- arguments, Array::ZoneHandle(), 1);
- ReturnComputation(call);
+
+ LoadIndexedComp* load = new LoadIndexedComp(
+ node->token_index(),
+ owner()->try_index(),
+ for_array.value(),
+ for_index.value());
+ ReturnComputation(load);
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/intermediate_language.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698