Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10538052: Allow --aura-host-window-use-fullscreen to be used without chromeos=1. (Closed)

Created:
8 years, 6 months ago by reveman
Modified:
8 years, 6 months ago
Reviewers:
danakj, Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Allow --aura-host-window-use-fullscreen to be used without chromeos=1. BUG=131744 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141212

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move set_hide_host_cursor call to within the OS_CHROMEOS block. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
Hi, this would be nice to land before host window management so that we can ...
8 years, 6 months ago (2012-06-08 05:33:44 UTC) #1
Daniel Erat
LGTM with a comment. https://chromiumcodereview.appspot.com/10538052/diff/1/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (right): https://chromiumcodereview.appspot.com/10538052/diff/1/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc#newcode55 chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:55: aura::RootWindow::set_hide_host_cursor(true); I think that this ...
8 years, 6 months ago (2012-06-08 13:25:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10538052/4001
8 years, 6 months ago (2012-06-08 13:49:54 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 15:34:06 UTC) #4
Change committed as 141212

Powered by Google App Engine
This is Rietveld 408576698