Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10538049: Merge 118711 - Can't edit <input> elements with :first-letter (Closed)

Created:
8 years, 6 months ago by Hajime Morrita
Modified:
8 years, 6 months ago
Reviewers:
gmorrita
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118711 - Can't edit <input> elements with :first-letter https://bugs.webkit.org/show_bug.cgi?id=87615 Reviewed by Kent Tamura. A check using canHaveGeneratedChildren() should cover not only button and menulist, but also RenderTextControl. This change pulles canHaveGeneratedChildren() up from RenderDeprecatedFlexibleBox to RenderObject, and lets RenderTextControl override it. Test: fast/forms/input-first-letter-edit.html * rendering/RenderBlock.cpp: (WebCore): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::updateFirstLetter): * rendering/RenderBlock.h: Removed a static function canHaveGeneratedChildren() (RenderBlock): * rendering/RenderDeprecatedFlexibleBox.h: * rendering/RenderObject.cpp: (WebCore): (WebCore::RenderObject::canHaveGeneratedChildren): Added. * rendering/RenderObject.h: (RenderObject): * rendering/RenderTextControl.h: TBR=morrita@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
A + LayoutTests/fast/forms/input-first-letter-edit.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/input-first-letter-edit-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBlock.cpp View 4 chunks +3 lines, -15 lines 0 comments Download
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderTextControl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hajime Morrita
8 years, 6 months ago (2012-06-08 01:21:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698