Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10538039: Renamed BrowserWindow::GetNativeHandle() to GetNativeWindow() (Closed)

Created:
8 years, 6 months ago by DaveMoore
Modified:
8 years, 6 months ago
Reviewers:
sky, Scott Byer
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, kkania, apatrick_chromium, Andrei, jennb, dtseng+watch_chromium.org, yuzo+watch_chromium.org, jianli, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, mihaip-chromium-reviews_chromium.org, hashimoto+watch_chromium.org, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, robertshield, rdsmith+dwatch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Renamed BrowserWindow::GetNativeHandle() to GetNativeWindow() This is in preparation for adding a GetNativeWindow() method to the BaseWindow interface. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141071

Patch Set 1 #

Patch Set 2 : Update copyrights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_action_test_util_gtk.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/keyboard_access_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/confirm_bubble_gtk_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_error_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/user_action_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/certificate_viewer_ui_test-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/android_native_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/android_native_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaveMoore
8 years, 6 months ago (2012-06-07 18:38:28 UTC) #1
sky
I looked at browser_window. Rubber stamp LGTM for the rest.
8 years, 6 months ago (2012-06-07 20:03:03 UTC) #2
DaveMoore
+scottbyer for printing OWNER
8 years, 6 months ago (2012-06-07 20:20:04 UTC) #3
Scott Byer
8 years, 6 months ago (2012-06-07 20:25:38 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698