Issue 10538027: Add shared memory cleanup before/after all tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10538027: Add shared memory cleanup before/after all tests (Closed)

Created:
8 years, 6 months ago by jar (doing other things)

Modified:
8 years, 6 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add shared memory cleanup before/after all tests Cleanup was already in place, but was missing for StatsRate and StatsCounterTimer. This should *hopefully* remove apparent flakiness seen when running StatsRate alone in a test bot. bug=131024 r=asvitkine Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140830

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	base/metrics/stats_table_unittest.cc	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/10538027/1

8 years, 6 months ago (2012-06-06 18:18:13 UTC) #3

jar (doing other things)

On 2012/06/06 18:11:35, Alexei Svitkine wrote: > LGTM Please take another look... I also re-enabled ...

8 years, 6 months ago (2012-06-06 19:17:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/10538027/5002

8 years, 6 months ago (2012-06-06 19:29:15 UTC) #6

Change committed as 140830

Expand Messages | Collapse Messages