Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 10538012: Correctly check length when allocating string. (Closed)

Created:
8 years, 6 months ago by Yang
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Correctly check length when allocating string. R=jkummerow@chromium.org BUG= TEST=regress-regexp-overflow.js Committed: https://code.google.com/p/v8/source/detail?r=11720

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/runtime.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
8 years, 6 months ago (2012-06-05 17:21:18 UTC) #1
Jakob Kummerow
As discussed offline: - the Windows compiler probably wants a cast for result_len - you'll ...
8 years, 6 months ago (2012-06-05 17:28:48 UTC) #2
Yang
On 2012/06/05 17:28:48, Jakob wrote: > As discussed offline: > - the Windows compiler probably ...
8 years, 6 months ago (2012-06-05 17:39:54 UTC) #3
Jakob Kummerow
8 years, 6 months ago (2012-06-05 17:41:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698