The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox …

remoting/webapp/host_setup_dialog.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 118 matching lines @@
       return;  // Otherwise the "submit" action can't be triggered by Enter.
     }
     if ((event.which >= 48) && (event.which <= 57)) {
       return;
     }
     event.preventDefault();
   };
   this.pinEntry_.addEventListener('keypress', onDaemonPinEntryKeyPress, false);
   this.pinEntry_.addEventListener('keypress', noDigitsInPin, false);
   this.pinConfirm_.addEventListener('keypress', noDigitsInPin, false);
+
+  this.usageStats_ = document.getElementById('usagestats-consent');
+  this.usageStatsCheckbox_ =
+      document.getElementById('usagestats-consent-checkbox');
 };
 
 /**
  * Show the dialog in order to get a PIN prior to starting the daemon. When the
  * user clicks OK, the dialog shows a spinner until the daemon has started.
  *
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.showForStart = function() {
+  /** @type {remoting.HostSetupDialog} */
+  var that = this;
+
+  /**
+   * @param {boolean} supported True if crash dumps reporting is supported by

[Jamie, 2012/06/21 18:47:52]

Nit: s/dumps/dump/ here and elsewhere.

[alexeypa (please no reviews), 2012/06/21 23:30:26]

Done.

+   *     the host.
+   * @param {boolean} allowed True if crash dumps reporting is allowed.
+   * @param {boolean} set_by_policy True if crash dump reporting is controlled
+   *     by policy.
+   */
+  var onGetConsent = function(supported, allowed, set_by_policy) {
+    that.usageStats_.hidden = !supported;
+    that.usageStatsCheckbox_.checked = allowed;
+    that.usageStatsCheckbox_.disabled = set_by_policy;
+  };
+  this.usageStats_.hidden = true;

[Jamie, 2012/06/21 18:47:52]

Optional: I'm not sure hiding it and having it appear when the callback
completes is correct. Certainly once all platforms support this it won't be
right, and I think since Windows is our main platform it's probably better just
to disable it here. Having the state transistion from disabled to enabled is
likely to be less jarring that having it appear.

[alexeypa (please no reviews), 2012/06/21 23:30:26]

Done.

+  this.hostController_.getConsent(onGetConsent);
+
   var flow = [
       remoting.HostSetupFlow.State.ASK_PIN,
       remoting.HostSetupFlow.State.STARTING_HOST,
       remoting.HostSetupFlow.State.HOST_STARTED];
 
   if (navigator.platform.indexOf('Mac') != -1 &&
       this.hostController_.state() ==
       remoting.HostController.State.NOT_INSTALLED) {
     flow.unshift(remoting.HostSetupFlow.State.INSTALL_HOST);
   }
 
   this.startNewFlow_(flow);
 };
 
 /**
  * Show the dialog in order to change the PIN associated with a running daemon.
  *
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.showForPin = function() {
+  this.usageStats_.hidden = true;
   this.startNewFlow_(
       [remoting.HostSetupFlow.State.ASK_PIN,
        remoting.HostSetupFlow.State.UPDATING_PIN,
        remoting.HostSetupFlow.State.UPDATED_PIN]);
 };
 
 /**
  * Show the dialog in order to stop the daemon.
  *
  * @return {void} Nothing.
@@ skipping 111 matching lines @@
   function onHostStarted(result) {
     if (flow !== that.flow_ ||
         flow.getState() != remoting.HostSetupFlow.State.STARTING_HOST) {
       console.error('Host setup was interrupted when starting the host');
       return;
     }
 
     flow.switchToNextStep(result);
     that.updateState_();
   }
-  this.hostController_.start(this.flow_.pin, onHostStarted);
+  this.hostController_.start(this.flow_.pin, this.flow_.consent, onHostStarted);
 };
 
 remoting.HostSetupDialog.prototype.updatePin_ = function() {
   /** @type {remoting.HostSetupDialog} */
   var that = this;
   /** @type {remoting.HostSetupFlow} */
   var flow = this.flow_;
 
   /** @param {remoting.HostController.AsyncResult} result */
   function onPinUpdated(result) {
@@ skipping 50 matching lines @@
   }
   if (!remoting.HostSetupDialog.validPin_(pin1)) {
     l10n.localizeElementFromTag(
         this.pinErrorMessage_, /*i18n-content*/'INVALID_PIN');
     this.pinErrorDiv_.hidden = false;
     this.prepareForPinEntry_();
     return;
   }
   this.pinErrorDiv_.hidden = true;
   this.flow_.pin = pin1;
+  /** @type {boolean} */
+  var consent = !this.usageStats_.hidden && this.usageStatsCheckbox_.checked;
+  this.flow_.consent = consent;
   this.flow_.switchToNextStep(remoting.HostController.AsyncResult.OK);
   this.updateState_();
 };
 
 /** @private */
 remoting.HostSetupDialog.prototype.prepareForPinEntry_ = function() {
   this.pinEntry_.value = '';
   this.pinConfirm_.value = '';
   this.pinEntry_.focus();
 };
@@ skipping 33 matching lines @@
 
 /**
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.onInstallDialogRetry = function() {
   remoting.setMode(remoting.AppMode.HOST_SETUP_INSTALL);
 }
 
 /** @type {remoting.HostSetupDialog} */
 remoting.hostSetupDialog = null;