The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox …

remoting/webapp/host_setup_dialog.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 118 matching lines @@
       return;  // Otherwise the "submit" action can't be triggered by Enter.
     }
     if ((event.which >= 48) && (event.which <= 57)) {
       return;
     }
     event.preventDefault();
   };
   this.pinEntry_.addEventListener('keypress', onDaemonPinEntryKeyPress, false);
   this.pinEntry_.addEventListener('keypress', noDigitsInPin, false);
   this.pinConfirm_.addEventListener('keypress', noDigitsInPin, false);
+
+  this.usageStatsConsent_ = document.getElementById('usagestats-consent');
+
+  /**
+   * @param {boolean} set_by_policy True if crash dump reporting is allowed by

[Jamie, 2012/06/14 23:43:56]

s/allowed/controlled/ (it might be disabled by policy)

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

+   *     the policy.

[Jamie, 2012/06/14 23:43:56]

s/the//

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

+   * @param {boolean} allowed True if crash dumps reporting is allowed.
+   */
+  var onGetConsent = function(set_by_policy, allowed) {
+    that.usageStatsConsent_.disabled = set_by_policy;
+    that.usageStatsConsent_.checked = allowed;
+  }
+  this.hostController_.getConsent(onGetConsent);

[Jamie, 2012/06/14 23:43:56]

This belongs in showForStart. I suspect it won't make any real difference in
practise, so we can cheat here if the asynchronous nature of getConsent is going
to make life difficult, but dialog initialization should take place in the show
method, not the constructor.

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

+
+  /** @param {boolean} Whether the consent checkbox is selected. */
+  var onConsentChange = function(checked) {
+    that.hostController_.setConsent(checked);
+  };
+  this.usageStatsConsent_.onchange = function() {
+    onConsentChange(this.checked);
+  };

[Jamie, 2012/06/14 23:43:56]

I think this would be better handled by deferring setting the policy until the
host is started, rather than trying to do it as soon as the checkbox changes. In
other words, add the logic to the onsubmit handler.

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

 };
 
 /**
  * Show the dialog in order to get a PIN prior to starting the daemon. When the
  * user clicks OK, the dialog shows a spinner until the daemon has started.
  *
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.showForStart = function() {

[Jamie, 2012/06/14 23:43:56]

showForStart should show the check-box if crash reporting is enabled.

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

   var flow = [
       remoting.HostSetupFlow.State.ASK_PIN,
       remoting.HostSetupFlow.State.STARTING_HOST,
       remoting.HostSetupFlow.State.HOST_STARTED];
 
   if (navigator.platform.indexOf('Mac') != -1 &&
       this.hostController_.state() ==
       remoting.HostController.State.NOT_INSTALLED) {
     flow.unshift(remoting.HostSetupFlow.State.INSTALL_HOST);
   }
 
   this.startNewFlow_(flow);
 };
 
 /**
  * Show the dialog in order to change the PIN associated with a running daemon.
  *
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.showForPin = function() {

[Jamie, 2012/06/14 23:43:56]

showForPin should hide the check-box. I don't think it makes sense to offer to
change this setting via the change-PIN dialog.

[alexeypa (please no reviews), 2012/06/19 23:27:29]

Done.

   this.startNewFlow_(
       [remoting.HostSetupFlow.State.ASK_PIN,
        remoting.HostSetupFlow.State.UPDATING_PIN,
        remoting.HostSetupFlow.State.UPDATED_PIN]);
 };
 
 /**
  * Show the dialog in order to stop the daemon.
  *
  * @return {void} Nothing.
@@ skipping 235 matching lines @@
 
 /**
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.onInstallDialogRetry = function() {
   remoting.setMode(remoting.AppMode.HOST_SETUP_INSTALL);
 }
 
 /** @type {remoting.HostSetupDialog} */
 remoting.hostSetupDialog = null;