Print full path in diagnostic messages building with ninja on windows.

Print full path in diagnostic messages building with ninja on windows.

This allows to click on messages in visual studio to open file with error or warning.
By default all path is relative to src/out/Debug but visual studio search file relative to location project.

Putting project into deeper directory to match default relative path is an option, but in this case you can't use 'Show All Files' in solution explorer to browse source tree.

BUG=none
TEST=none
Committed: https://code.google.com/p/gyp/source/detail?r=1417

[scottmg, 2012-06-15 21:15:02]

That's a good idea, it's annoying have the (wrong) out\Debug-relative path. We
should probably put it into gyp instead though, as we try to avoid <(GENERATOR)
as much as possible. Would you mind making a gyp patch instead?

[Vitaly Buka (NO REVIEWS), 2012-06-16 04:05:44]

Print full path in diagnostic messages building with ninja on windows. 

This allows to click on messages in visual studio to open file with error or
warning. 
By default all path is relative to src/out/Debug but visual studio search file
relative to location project. 

Putting project into deeper directory to match default relative path is an
option, but in this case you can't use 'Show All Files' in solution explorer to
browse source tree. 

BUG=none
TEST=none

[Vitaly Buka (NO REVIEWS), 2012-06-16 04:06:40]

Done.
On 2012/06/15 21:15:02, scottmg wrote:
> That's a good idea, it's annoying have the (wrong) out\Debug-relative path. We
> should probably put it into gyp instead though, as we try to avoid
<(GENERATOR)
> as much as possible. Would you mind making a gyp patch instead?

[scottmg, 2012-06-18 20:15:37]

lgtm

[commit-bot: I haz the power, 2012-06-18 20:17:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10537170/11001

[commit-bot: I haz the power, 2012-06-18 20:17:35]

Failed to apply patch for pylib/gyp/generator/ninja.py:
While running patch -p0 --forward --force;
A         pylib
A         pylib/gyp
A         pylib/gyp/generator
patching file pylib/gyp/generator/ninja.py
Hunk #1 FAILED at 1305.
1 out of 1 hunk FAILED -- saving rejects to file
pylib/gyp/generator/ninja.py.rej

[scottmg, 2012-06-18 20:18:48]

On 2012/06/18 20:17:35, I haz the power (commit-bot) wrote:
> Failed to apply patch for pylib/gyp/generator/ninja.py:
> While running patch -p0 --forward --force;
> A         pylib
> A         pylib/gyp
> A         pylib/gyp/generator
> patching file pylib/gyp/generator/ninja.py
> Hunk #1 FAILED at 1305.
> 1 out of 1 hunk FAILED -- saving rejects to file
> pylib/gyp/generator/ninja.py.rej

The base is /trunk/src it'll have to be relative to the gyp dir, but I don't
think you can change that from the exposed UI.

[M-A Ruel, 2012-06-18 20:24:55]

On 2012/06/18 20:18:48, scottmg wrote:
> On 2012/06/18 20:17:35, I haz the power (commit-bot) wrote:
> > Failed to apply patch for pylib/gyp/generator/ninja.py:
> > While running patch -p0 --forward --force;
> > A         pylib
> > A         pylib/gyp
> > A         pylib/gyp/generator
> > patching file pylib/gyp/generator/ninja.py
> > Hunk #1 FAILED at 1305.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > pylib/gyp/generator/ninja.py.rej
> 
> The base is /trunk/src it'll have to be relative to the gyp dir, but I don't
> think you can change that from the exposed UI.

There's no CQ for gyp at the moment.

[Vitaly Buka (NO REVIEWS), 2012-06-18 20:33:23]

How can I commit this CL?
I have no commiter access to this repo.