Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4561)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 10537158: Add support for Ash to Notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Undo accidental UserManagerImpl change Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/locale_change_guard.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 909ef7aec71e823c95a0901379d936c7fcc4e74c..c1edaba15c3b8067201eb133dc2c041b24ca8a1f 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -64,13 +64,13 @@ class CrashNotificationDelegate : public NotificationDelegate {
extension_id_(extension->id()) {
}
- void Display() {}
+ virtual void Display() OVERRIDE {}
- void Error() {}
+ virtual void Error() OVERRIDE {}
- void Close(bool by_user) {}
+ virtual void Close(bool by_user) OVERRIDE {}
- void Click() {
+ virtual void Click() OVERRIDE {
if (is_hosted_app_) {
// There can be a race here: user clicks the balloon, and simultaneously
// reloads the sad tab for the app. So we check here to be safe before
@@ -88,10 +88,14 @@ class CrashNotificationDelegate : public NotificationDelegate {
ScheduleCloseBalloon(extension_id_);
}
- std::string id() const {
+ virtual std::string id() const OVERRIDE {
return kNotificationPrefix + extension_id_;
}
+ virtual content::RenderViewHost* GetRenderViewHost() const OVERRIDE {
+ return NULL;
+ }
+
private:
virtual ~CrashNotificationDelegate() {}
« no previous file with comments | « no previous file | chrome/browser/chromeos/locale_change_guard.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698