chrome/browser/autocomplete/keyword_provider.cc - Issue 10537154: A working implementation of AQS (Assisted Query Stats).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/keyword_provider.cc

Issue 10537154: A working implementation of AQS (Assisted Query Stats). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addressed comments and added more docs. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/keyword_provider.cc

diff --git a/chrome/browser/autocomplete/keyword_provider.cc b/chrome/browser/autocomplete/keyword_provider.cc

index fdd54890935bf2b83e70f47869be7ae92a1c83ae..b50720f15043ea3d66323f7bd50478d0e8227b21 100644

--- a/chrome/browser/autocomplete/keyword_provider.cc

+++ b/chrome/browser/autocomplete/keyword_provider.cc

@@ -396,7 +396,7 @@ void KeywordProvider::FillInURLAndContents(

// fixup to make the URL valid if necessary.

DCHECK(element_ref.SupportsReplacement());

match->destination_url = GURL(element_ref.ReplaceSearchTerms(

- remaining_input, TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16()));

+ TemplateURLRef::SearchTermsArgs(remaining_input)));

std::vector<size_t> content_param_offsets;

match->contents.assign(l10n_util::GetStringFUTF16(message_id,

element->short_name(),