chrome/browser/search_engines/template_url_service.cc - Issue 10537154: A working implementation of AQS (Assisted Query Stats).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_service.cc

Issue 10537154: A working implementation of AQS (Assisted Query Stats). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixed InstantTest.OnChangeEvent failure; addressed remaining commments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search_engines/template_url_service.cc

diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc

index 7f7b6623f4b60e004e60f91afc904bd5df31e392..1f26f0fc9d2ec1494988bc5d20ecb54662caf683 100644

--- a/chrome/browser/search_engines/template_url_service.cc

+++ b/chrome/browser/search_engines/template_url_service.cc

@@ -318,8 +318,8 @@ GURL TemplateURLService::GenerateSearchURLUsingTermsData(

return GURL(t_url->url());

return GURL(search_ref.ReplaceSearchTermsUsingTermsData(

- ASCIIToUTF16(kReplacementTerm), TemplateURLRef::NO_SUGGESTIONS_AVAILABLE,

- string16(), search_terms_data));

+ TemplateURLRef::SearchTermsArgs(ASCIIToUTF16(kReplacementTerm)),

+ search_terms_data));

}

bool TemplateURLService::CanReplaceKeyword(