Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10537116: Revert 141514 - Remove CachingValueStore in favor of an async ValueStoreFrontend. (Closed)

Created:
8 years, 6 months ago by inferno
Modified:
8 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 141514 - Remove CachingValueStore in favor of an async ValueStoreFrontend. Caused massive number of use-after-free crashes on ClusterFuzz. After actually seeing the use cases for the value store in extension code, I realized that an async version would be more appropriate. This one will use less memory as well, since we won't need to keep the cache in memory. BUG=123366 TEST=no Review URL: https://chromiumcodereview.appspot.com/10539073 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -276 lines) Patch
A + chrome/browser/value_store/caching_value_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/value_store/caching_value_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/value_store/caching_value_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/value_store/value_store_frontend.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/value_store/value_store_frontend.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/value_store/value_store_frontend_unittest.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
8 years, 6 months ago (2012-06-12 03:11:52 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698