Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: chrome/test/functional/perf.py

Issue 10537111: Fix bug in pyauto perf tests where list containing result 0 isn't handled properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/perf.py
diff --git a/chrome/test/functional/perf.py b/chrome/test/functional/perf.py
index a7a8342062a29df1678f29cacf51c1003a6e2d7d..6314ea3849c41b8568f4a68c2f2a9ee31e11f9b0 100755
--- a/chrome/test/functional/perf.py
+++ b/chrome/test/functional/perf.py
@@ -376,14 +376,15 @@ class BasePerfTest(pyauto.PyUITest):
are iteration numbers. If this argument is specified, then the
|value| argument must be a list of (x, y) tuples.
"""
- if isinstance(value, list) and value[0] and isinstance(value[0], tuple):
+ if (isinstance(value, list) and value[0] is not None and
+ isinstance(value[0], tuple)):
assert units_x
if units_x:
assert isinstance(value, list)
if self.IsChromeOS():
# ChromeOS results don't support lists.
- if (isinstance(value, list) and value[0] and
+ if (isinstance(value, list) and value[0] is not None and
not isinstance(value[0], tuple)):
value = Mean(value)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698