Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10537111: Fix bug in pyauto perf tests where list containing result 0 isn't handled properly. (Closed)

Created:
8 years, 6 months ago by dennis_jeffrey
Modified:
8 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, rohitbm
Visibility:
Public.

Description

Fix bug in pyauto perf tests where list containing result 0 isn't handled properly. Previously, 2 conditions in the code verified an appropriate perf result value in a list by implicitly converting that value to a boolean. As a result, a list value of 0 would be assumed to be invalid, when in fact a perf result value of 0 may be appropriate. This CL changes the logic of these conditions by comparing the list value to None. That way, even a list value of 0 will still be considered an appropriate value. BUG=None TEST=Ran test perf.YoutubePerfTest on a local ChromeOS device, which fails without this change, but passes with it. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/functional/perf.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dennis_jeffrey
This CL should fix perf.YoutubePerfTest.testYoutubeDroppedFrames, which currently fails on ChromeOS.
8 years, 6 months ago (2012-06-11 23:00:24 UTC) #1
tonyg
lgtm
8 years, 6 months ago (2012-06-12 19:14:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/10537111/1
8 years, 6 months ago (2012-06-12 19:15:53 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 19:16:33 UTC) #4
Change committed as 141703

Powered by Google App Engine
This is Rietveld 408576698