Issue 10537097: browser: Move dock_info* into their ui/ specific directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10537097: browser: Move dock_info* into their ui/ specific directories. (Closed)

Created:
8 years, 6 months ago by tfarina

Modified:
8 years, 6 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

browser: Move dock_info* into their ui/ specific directories. That way we isolate dock_info_win in views/ directory so it can include files from chrome/browser/ui/views/. BUG=125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141718

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -676 lines)			Patch
A +	chrome/browser/ui/ash/tabs/dock_info_ash.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/aura/tabs/dock_info_aura.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/tabs/dock_info_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/gtk/tabs/dock_info_gtk.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/ui/tabs/dock_info_ash.cc	View	1 chunk	+0 lines, -71 lines	0 comments	Download
D	chrome/browser/ui/tabs/dock_info_aura.cc	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/ui/tabs/dock_info_gtk.cc	View	1 chunk	+0 lines, -215 lines	0 comments	Download
D	chrome/browser/ui/tabs/dock_info_mac.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	chrome/browser/ui/tabs/dock_info_win.cc	View	1 chunk	+0 lines, -334 lines	0 comments	Download
A +	chrome/browser/ui/views/tabs/dock_info_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	7 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

tfarina

Hi Scott, in the absence of Ben, could you approve this CL? Thanks.

8 years, 6 months ago (2012-06-11 23:31:27 UTC) #2

sky

This LGTM, but I remember at one point Ben wanting ash to live under views ...

8 years, 6 months ago (2012-06-12 04:12:32 UTC) #3

Ben Goodger (Google)

8 years, 6 months ago (2012-06-12 18:34:41 UTC) #4

For ash specific-stuff not part of the views frontend, sure.