Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2657)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_view_impl.cc

Issue 10537091: add url as additional argument to createMediaPlayer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | webkit/support/webkit_support.h » ('j') | webkit/support/webkit_support.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 151527)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -2362,7 +2362,13 @@
}
}
+// TODO(wjia): remove the version without url when WebKit change is done.
scherkus (not reviewing) 2012/08/15 22:53:57 can you annotate which webkit bug? http://webk.it
wjia(left Chromium) 2012/08/15 23:14:35 Done.
WebMediaPlayer* RenderViewImpl::createMediaPlayer(
+ WebFrame* frame, const WebKit::WebURL& url, WebMediaPlayerClient* client) {
+ return createMediaPlayer(frame, client);
+}
+
+WebMediaPlayer* RenderViewImpl::createMediaPlayer(
WebFrame* frame, WebMediaPlayerClient* client) {
FOR_EACH_OBSERVER(
RenderViewObserver, observers_, WillCreateMediaPlayer(frame, client));
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | webkit/support/webkit_support.h » ('j') | webkit/support/webkit_support.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698