Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 10537082: Remove duplicate CPU detection code; use base::CPU instead. (Closed)

Created:
8 years, 6 months ago by DaleCurtis
Modified:
8 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, feature-media-reviews_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove duplicate CPU detection code; use base::CPU instead. BUG=none TEST=media_unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141627

Patch Set 1 #

Patch Set 2 : Remove static initializers. #

Total comments: 1

Patch Set 3 : int->bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -206 lines) Patch
M base/cpu.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
D media/base/cpu_features.h View 1 chunk +0 lines, -27 lines 0 comments Download
D media/base/cpu_features_arm.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D media/base/cpu_features_x86.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M media/base/simd/convert_rgb_to_yuv_ssse3.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/simd/convert_rgb_to_yuv_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb_x86.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/yuv_convert.cc View 1 9 chunks +22 lines, -14 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 12 chunks +23 lines, -12 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M remoting/host/differ_block.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
DaleCurtis
8 years, 6 months ago (2012-06-08 18:40:03 UTC) #1
Sergey Ulanov
remoting - lGTM
8 years, 6 months ago (2012-06-08 19:11:18 UTC) #2
DaleCurtis
Removed static initializers. There should be ~0 performance difference since all of these calls are ...
8 years, 6 months ago (2012-06-09 02:36:08 UTC) #3
scherkus (not reviewing)
lgtm+++++++++++ https://chromiumcodereview.appspot.com/10537082/diff/3001/media/base/yuv_convert.cc File media/base/yuv_convert.cc (right): https://chromiumcodereview.appspot.com/10537082/diff/3001/media/base/yuv_convert.cc#newcode131 media/base/yuv_convert.cc:131: filter_proc = ChooseFilterYUVRowsProc(); ah so in reality we ...
8 years, 6 months ago (2012-06-12 02:11:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10537082/3001
8 years, 6 months ago (2012-06-12 02:13:33 UTC) #5
DaleCurtis
+darin for base/cpu.h change, which appears to be a copy/paste error.
8 years, 6 months ago (2012-06-12 02:41:40 UTC) #6
darin (slow to review)
LGTM for base/ change
8 years, 6 months ago (2012-06-12 04:43:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10537082/13001
8 years, 6 months ago (2012-06-12 04:50:01 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 08:29:34 UTC) #9
Change committed as 141627

Powered by Google App Engine
This is Rietveld 408576698