src/isolate.cc - Issue 10537078: Preserve error message during finally block in try..finally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 10537078: Preserve error message during finally block in try..finally. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 6fcc926f259a9b6ee07c2dc28a7f7084f6b4b208..8a186c92e542e336d025b71ce1e0621bd6ddf03d 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -921,7 +921,7 @@ Failure* Isolate::Throw(Object* exception, MessageLocation* location) {

}

-Failure* Isolate::ReThrow(MaybeObject* exception, MessageLocation* location) {

+Failure* Isolate::ReThrow(MaybeObject* exception) {

bool can_be_caught_externally = false;

bool catchable_by_javascript = is_catchable_by_javascript(exception);

ShouldReportException(&can_be_caught_externally, catchable_by_javascript);

« no previous file with comments | « src/isolate.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »