Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10537069: Change checkdeps.py to stop scanning after a certain number of non-include lines. (Closed)

Created:
8 years, 6 months ago by mattm
Modified:
8 years, 6 months ago
Reviewers:
brettw, M-A Ruel
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Change checkdeps.py to stop scanning after a certain number of non-include lines. Previously it would always scan 150 lines, even if the file had more includes than that. Also, break out of the loop once we reach the end of the file, rather than looping and testing the empty string until we hit the limit. BUG=131315 TEST=In a file with lots of includes, introduce an illegal one at the end. Run checkdeps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M tools/checkdeps/checkdeps.py View 6 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
8 years, 6 months ago (2012-06-08 03:40:29 UTC) #1
brettw
lgtm
8 years, 6 months ago (2012-06-08 18:21:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/10537069/1
8 years, 6 months ago (2012-06-08 19:47:18 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 20:55:17 UTC) #4
Change committed as 141283

Powered by Google App Engine
This is Rietveld 408576698