Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 10537067: mac: Basic HighDPI implementation for web contents. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, oshima, pkotwicz, zlieber_chromium.org
Visibility:
Public.

Description

mac: Basic HighDPI implementation for web contents. Depends on https://bugs.webkit.org/show_bug.cgi?id=88596 The basics work, but a lot of stuff is broken (e.g. switching resolutions while chrome is running). BUG=31960 TEST=Go HighDPI, launch chrome. No longer pixely. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141211

Patch Set 1 #

Patch Set 2 : simpler #

Patch Set 3 : done #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 chunks +26 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_mac.mm View 1 chunk +9 lines, -0 lines 2 comments Download
M ui/gfx/screen_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 6 months ago (2012-06-08 01:03:10 UTC) #1
Avi (use Gerrit)
Your code lgtm. https://chromiumcodereview.appspot.com/10537067/diff/3001/ui/gfx/screen_mac.mm File ui/gfx/screen_mac.mm (right): https://chromiumcodereview.appspot.com/10537067/diff/3001/ui/gfx/screen_mac.mm#newcode92 ui/gfx/screen_mac.mm:92: gfx::Monitor Screen::GetMonitorNearestWindow(gfx::NativeView view) { GetMonitorNearestWindow takes ...
8 years, 6 months ago (2012-06-08 14:41:43 UTC) #2
Nico
Thanks! https://chromiumcodereview.appspot.com/10537067/diff/3001/ui/gfx/screen_mac.mm File ui/gfx/screen_mac.mm (right): https://chromiumcodereview.appspot.com/10537067/diff/3001/ui/gfx/screen_mac.mm#newcode92 ui/gfx/screen_mac.mm:92: gfx::Monitor Screen::GetMonitorNearestWindow(gfx::NativeView view) { On 2012/06/08 14:41:43, Avi ...
8 years, 6 months ago (2012-06-08 14:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10537067/3001
8 years, 6 months ago (2012-06-08 14:43:20 UTC) #4
commit-bot: I haz the power
Presubmit check for 10537067-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-08 14:43:22 UTC) #5
Nico
sky: owners
8 years, 6 months ago (2012-06-08 14:47:46 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 14:48:02 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698