Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10537062: TabContentsWrapper -> TabContents, part 13. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 13. ui/tabs BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141309

Patch Set 1 #

Patch Set 2 : forgot the second half #

Patch Set 3 : more files #

Patch Set 4 : missing decl #

Patch Set 5 : better #

Patch Set 6 : fiz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -405 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_finder.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 21 chunks +73 lines, -74 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 30 chunks +51 lines, -57 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_delegate.h View 1 6 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 4 chunks +21 lines, -22 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 70 chunks +160 lines, -163 lines 0 comments Download
M chrome/browser/ui/tabs/test_tab_strip_model_delegate.h View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-08 18:32:01 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-08 20:35:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10537062/1009
8 years, 6 months ago (2012-06-08 20:42:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 10537062-1009 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-08 20:42:58 UTC) #4
Avi (use Gerrit)
Randy, you're an OWNER and responsive.
8 years, 6 months ago (2012-06-08 21:07:47 UTC) #5
Randy Smith (Not in Mondays)
On 2012/06/08 21:07:47, Avi wrote: > Randy, you're an OWNER and responsive. Of course, it's ...
8 years, 6 months ago (2012-06-08 21:36:40 UTC) #6
Avi (use Gerrit)
It's a rename of a function; see the other files in the changelist.
8 years, 6 months ago (2012-06-08 21:46:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10537062/1009
8 years, 6 months ago (2012-06-08 21:47:13 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 22:44:19 UTC) #9
Change committed as 141309

Powered by Google App Engine
This is Rietveld 408576698