Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 10537059: Add ApiBase.Tracer.post_process_log() to do implementation specific one-time mangling of the logs. (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
cmp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add ApiBase.Tracer.post_process_log() to do implementation specific one-time mangling of the logs. This permits, along with the 'with' statement, to have automatic fix up of the logs upon tracing session termination. Standardize on "logname" variable instead of "filename". Still move more code around a bit. NOTRY=true R=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -210 lines) Patch
M tools/isolate/trace_inputs.py View 11 chunks +209 lines, -210 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 6 months ago (2012-06-07 21:00:09 UTC) #1
cmp
lgtm
8 years, 6 months ago (2012-06-08 00:24:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10537059/1
8 years, 6 months ago (2012-06-08 18:07:39 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 18:09:33 UTC) #4
Change committed as 141238

Powered by Google App Engine
This is Rietveld 408576698