Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: base/win/scoped_handle.cc

Issue 10537041: Base: Add another pc to the handle verifier to get to the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/win/scoped_handle.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/scoped_handle.h" 5 #include "base/win/scoped_handle.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 9
10 #include "base/debug/alias.h" 10 #include "base/debug/alias.h"
11 #include "base/lazy_instance.h" 11 #include "base/lazy_instance.h"
12 #include "base/synchronization/lock.h" 12 #include "base/synchronization/lock.h"
13 #include "base/win/windows_version.h" 13 #include "base/win/windows_version.h"
14 14
15 namespace { 15 namespace {
16 16
17 struct Info { 17 struct Info {
18 const void* owner; 18 const void* owner;
19 const void* pc; 19 const void* pc1;
20 const void* pc2;
20 DWORD thread_id; 21 DWORD thread_id;
21 }; 22 };
22 typedef std::map<HANDLE, Info> HandleMap; 23 typedef std::map<HANDLE, Info> HandleMap;
23 24
24 base::LazyInstance<HandleMap>::Leaky g_handle_map = LAZY_INSTANCE_INITIALIZER; 25 base::LazyInstance<HandleMap>::Leaky g_handle_map = LAZY_INSTANCE_INITIALIZER;
25 base::LazyInstance<std::set<const void*> >::Leaky g_owner_set = 26 base::LazyInstance<std::set<const void*> >::Leaky g_owner_set =
26 LAZY_INSTANCE_INITIALIZER; 27 LAZY_INSTANCE_INITIALIZER;
27 base::LazyInstance<base::Lock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER; 28 base::LazyInstance<base::Lock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
28 29
29 } // namespace 30 } // namespace
30 31
31 namespace base { 32 namespace base {
32 namespace win { 33 namespace win {
33 34
34 // Static. 35 // Static.
35 void VerifierTraits::StartTracking(HANDLE handle, const void* owner, 36 void VerifierTraits::StartTracking(HANDLE handle, const void* owner,
36 const void* pc) { 37 const void* pc1, const void* pc2) {
37 if (OSInfo::GetInstance()->version() > VERSION_XP) 38 if (OSInfo::GetInstance()->version() > VERSION_XP)
38 return; 39 return;
39 40
40 // Grab the thread id before the lock. 41 // Grab the thread id before the lock.
41 DWORD thread_id = GetCurrentThreadId(); 42 DWORD thread_id = GetCurrentThreadId();
42 43
43 AutoLock lock(g_lock.Get()); 44 AutoLock lock(g_lock.Get());
44 45
45 if (handle == INVALID_HANDLE_VALUE) { 46 if (handle == INVALID_HANDLE_VALUE) {
46 // Cannot track this handle. 47 // Cannot track this handle.
47 g_owner_set.Get().insert(owner); 48 g_owner_set.Get().insert(owner);
48 return; 49 return;
49 } 50 }
50 51
51 Info handle_info = { owner, pc, thread_id }; 52 Info handle_info = { owner, pc1, pc2, thread_id };
52 std::pair<HANDLE, Info> item(handle, handle_info); 53 std::pair<HANDLE, Info> item(handle, handle_info);
53 std::pair<HandleMap::iterator, bool> result = g_handle_map.Get().insert(item); 54 std::pair<HandleMap::iterator, bool> result = g_handle_map.Get().insert(item);
54 if (!result.second) { 55 if (!result.second) {
55 Info other = result.first->second; 56 Info other = result.first->second;
56 debug::Alias(&other); 57 debug::Alias(&other);
57 CHECK(false); 58 CHECK(false);
58 } 59 }
59 } 60 }
60 61
61 // Static. 62 // Static.
62 void VerifierTraits::StopTracking(HANDLE handle, const void* owner, 63 void VerifierTraits::StopTracking(HANDLE handle, const void* owner,
63 const void* pc) { 64 const void* pc1, const void* pc2) {
64 if (OSInfo::GetInstance()->version() > VERSION_XP) 65 if (OSInfo::GetInstance()->version() > VERSION_XP)
65 return; 66 return;
66 67
67 AutoLock lock(g_lock.Get()); 68 AutoLock lock(g_lock.Get());
68 HandleMap::iterator i = g_handle_map.Get().find(handle); 69 HandleMap::iterator i = g_handle_map.Get().find(handle);
69 if (i == g_handle_map.Get().end()) { 70 if (i == g_handle_map.Get().end()) {
70 std::set<const void*>::iterator j = g_owner_set.Get().find(owner); 71 std::set<const void*>::iterator j = g_owner_set.Get().find(owner);
71 if (j != g_owner_set.Get().end()) { 72 if (j != g_owner_set.Get().end()) {
72 g_owner_set.Get().erase(j); 73 g_owner_set.Get().erase(j);
73 return; 74 return;
74 } 75 }
75 CHECK(false); 76 CHECK(false);
76 } 77 }
77 78
78 Info other = i->second; 79 Info other = i->second;
79 if (other.owner != owner) { 80 if (other.owner != owner) {
80 debug::Alias(&other); 81 debug::Alias(&other);
81 CHECK(false); 82 CHECK(false);
82 } 83 }
83 84
84 g_handle_map.Get().erase(i); 85 g_handle_map.Get().erase(i);
85 } 86 }
86 87
87 } // namespace win 88 } // namespace win
88 } // namespace base 89 } // namespace base
OLDNEW
« no previous file with comments | « base/win/scoped_handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698