Issue 10537041: Base: Add another pc to the handle verifier to get to the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10537041: Base: Add another pc to the handle verifier to get to the (Closed)

Created:
8 years, 6 months ago by rvargas (doing something else)

Modified:
8 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Base: Add another pc to the handle verifier to get to the actual caller. I was hoping for an inlining that didn't happened. BUG=127931 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140899

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -13 lines)			Patch
	M	base/win/scoped_handle.h	View		7 chunks	+24 lines, -9 lines	0 comments	Download
	M	base/win/scoped_handle.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Why don't we just base::debug::StackTrace? It's not like the scoped handle is widely used, so ...

8 years, 6 months ago (2012-06-06 23:58:11 UTC) #2

rvargas (doing something else)

8 years, 6 months ago (2012-06-07 00:24:54 UTC) #3

On 2012/06/06 23:58:11, willchan wrote:
> Why don't we just base::debug::StackTrace? It's not like the scoped handle is
> widely used, so it shouldn't have much cost. For a single canary release, I
> think the cost is worth it.

That code requires DbgHelp and it can get confused by optimized builds without
symbols, so yes, it is a lot more expensive.

I doubt this will be in for a single canary release :). It should go away, but
probably not that soon.

> 
> That said, if you prefer this approach, LGTM.

Thanks.

Expand Messages | Collapse Messages