Upgrade process: Add an error message for when CoCreateInstance fails.

Upgrade process: Add an error message for when CoCreateInstance fails.

BUG=96477
TEST=This requires a special build of Google Update to test...
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141205

[S. Ganesh, 2012-06-07 00:08:01]

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
File chrome/browser/google/google_update.cc (right):

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
chrome/browser/google/google_update.cc:313: if (system_level)
Prefer { }

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
chrome/browser/google/google_update.cc:333: string16(), main_loop);
Report a string for this case as well?

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
chrome/browser/google/google_update.cc:347: string16(), main_loop);
Report a string for this case as well?

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
chrome/browser/google/google_update.cc:361: string16(), main_loop);
Report a string for this case as well?

[Finnur, 2012-06-07 10:43:29]

PTAL

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
File chrome/browser/google/google_update.cc (right):

https://chromiumcodereview.appspot.com/10537039/diff/5001/chrome/browser/goog...
chrome/browser/google/google_update.cc:313: if (system_level)
Chrome team doesn't. 

On 2012/06/07 00:08:01, ganesh wrote:
> Prefer { }

[S. Ganesh, 2012-06-07 21:23:02]

https://chromiumcodereview.appspot.com/10537039/diff/2002/chrome/browser/goog...
File chrome/browser/google/google_update.cc (right):

https://chromiumcodereview.appspot.com/10537039/diff/2002/chrome/browser/goog...
chrome/browser/google/google_update.cc:312: L"%d: 0x%x",
GOOGLE_UPDATE_ONDEMAND_CLASS_NOT_FOUND, hr);
Since the value is repeated and needs to be in sync, perhaps have a variable
that is assigned GOOGLE_UPDATE_ONDEMAND_CLASS_NOT_FOUND, and use it in the 2
occurences. Same for other cases where ReportFailure is called in this file.

https://chromiumcodereview.appspot.com/10537039/diff/2002/chrome/browser/goog...
chrome/browser/google/google_update.cc:336: IDS_ABOUT_BOX_ERROR_COCREATE_FAILED,
Technically this is not a CoCreate failure. I presume the error message is
generic enough that it does not confuse the user?

https://chromiumcodereview.appspot.com/10537039/diff/2002/chrome/browser/goog...
chrome/browser/google/google_update.cc:356: IDS_ABOUT_BOX_ERROR_COCREATE_FAILED,
Technically this is not a CoCreate failure. I presume the error message is
generic enough that it does not confuse the user?

https://chromiumcodereview.appspot.com/10537039/diff/2002/chrome/browser/goog...
chrome/browser/google/google_update.cc:375: IDS_ABOUT_BOX_ERROR_COCREATE_FAILED,
Technically this is not a CoCreate failure. I presume the error message is
generic enough that it does not confuse the user?

[Finnur, 2012-06-08 13:52:36]

PTAL

http://codereview.chromium.org/10537039/diff/2002/chrome/browser/google/googl...
File chrome/browser/google/google_update.cc (right):

http://codereview.chromium.org/10537039/diff/2002/chrome/browser/google/googl...
chrome/browser/google/google_update.cc:375: IDS_ABOUT_BOX_ERROR_COCREATE_FAILED,
The variable name is a bit misleading but the error message is generic. I've
changed the varible name to be more generic.

On 2012/06/07 21:23:02, ganesh wrote:
> Technically this is not a CoCreate failure. I presume the error message is
> generic enough that it does not confuse the user?

[S. Ganesh, 2012-06-08 14:45:23]

lgtm