Added rendering benchmark javascript hook

content/renderer/gpu/gpu_benchmarking_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
+
+#include <string>
+#include <vector>
+
+#include "content/public/renderer/render_thread.h"
+#include "content/renderer/all_rendering_benchmarks.h"
+#include "content/renderer/rendering_benchmark.h"
+#include "content/renderer/rendering_benchmark_results.h"
 #include "content/renderer/render_view_impl.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebRenderingStats.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "v8/include/v8.h"
 
 using WebKit::WebFrame;
+using WebKit::WebPrivatePtr;
+using WebKit::WebViewBenchmarkSupport;
 using WebKit::WebRenderingStats;
 using WebKit::WebView;
 
 const char kGpuBenchmarkingExtensionName[] = "v8/GpuBenchmarking";
 
 using WebKit::WebFrame;
 using WebKit::WebView;
 
 namespace content {
 
+// Benchmark results object that populates a v8 array.
+class V8BenchmarkResults : public content::RenderingBenchmarkResults {
+ public:
+  explicit V8BenchmarkResults(v8::Handle<v8::Array> results_array)

[nduca, 2012/07/20 20:30:09]

why not have the array inside here and have an accessor instead?

E.g. V8BenchmarkResults() { results_array_ = new ...; }

and then an accessor results_array() { return results_array_; }

[dmurph, 2012/07/20 20:52:33]

The results object doesn't own the array though, the array will persist after
the results object is destructed.

[dmurph, 2012/07/20 21:11:41]

After discussion we realized v8 handles destruction with handles, so we can just
create the array in the results object and grab it from a setter w/o having to
worry about it destructing.

+    : results_array_(results_array) { }
+  virtual ~V8BenchmarkResults() {}
+
+  void addResult(const std::string& benchmark_name,
+                 const std::string& result_name,
+                 const std::string& result_unit,
+                 double result) {
+    v8::Handle<v8::Object> result_object = v8::Object::New();
+    result_object->Set(v8::String::New("benchmarkName", 13),
+                       v8::String::New(benchmark_name.c_str(), -1));
+    result_object->Set(v8::String::New("resultName", 10),
+                       v8::String::New(result_name.c_str(), -1));
+    result_object->Set(v8::String::New("resultUnit", 10),
+                       v8::String::New(result_unit.c_str(), -1));
+    result_object->Set(v8::String::New("result", 6), v8::Number::New(result));
+
+    results_array_->Set(results_array_->Length(), result_object);
+  }
+
+ private:
+  v8::Handle<v8::Array> results_array_;
+};
+
 class GpuBenchmarkingWrapper : public v8::Extension {
  public:
   GpuBenchmarkingWrapper() :
       v8::Extension(kGpuBenchmarkingExtensionName,
           "if (typeof(chrome) == 'undefined') {"
           "  chrome = {};"
           "};"
           "if (typeof(chrome.gpuBenchmarking) == 'undefined') {"
           "  chrome.gpuBenchmarking = {};"
           "};"
           "chrome.gpuBenchmarking.renderingStats = function() {"
           "  native function GetRenderingStats();"
           "  return GetRenderingStats();"
           "};"
           "chrome.gpuBenchmarking.beginSmoothScrollDown = "
           "    function(scroll_far) {"
           "  scroll_far = scroll_far || false;"
           "  native function BeginSmoothScroll();"
           "  return BeginSmoothScroll(true, scroll_far);"
           "};"
           "chrome.gpuBenchmarking.beginSmoothScrollUp = function(scroll_far) {"
           "  scroll_far = scroll_far || false;"
           "  native function BeginSmoothScroll();"
           "  return BeginSmoothScroll(false, scroll_far);"
+          "};"
+          "chrome.gpuBenchmarking.runRenderingBenchmarks = function(filter) {"
+          "  native function RunRenderingBenchmarks();"
+          "  return RunRenderingBenchmarks(filter);"
           "};") {}
 
   virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
       v8::Handle<v8::String> name) {
     if (name->Equals(v8::String::New("GetRenderingStats")))
       return v8::FunctionTemplate::New(GetRenderingStats);
     if (name->Equals(v8::String::New("BeginSmoothScroll")))
       return v8::FunctionTemplate::New(BeginSmoothScroll);
-
+    if (name->Equals(v8::String::New("RunRenderingBenchmarks")))
+      return v8::FunctionTemplate::New(RunRenderingBenchmarks);

[nduca, 2012/07/20 20:30:09]

i think there's a blank line after the ifs

[dmurph, 2012/07/20 20:52:33]

Done.

     return v8::Handle<v8::FunctionTemplate>();
   }
 
   static v8::Handle<v8::Value> GetRenderingStats(const v8::Arguments& args) {
     WebFrame* web_frame = WebFrame::frameForEnteredContext();
     if (!web_frame)
       return v8::Undefined();
 
     WebView* web_view = web_frame->view();
     if (!web_view)
@@ skipping 29 matching lines @@
 
     if (args.Length() != 2 || !args[0]->IsBoolean() || !args[1]->IsBoolean())
       return v8::False();
 
     bool scroll_down = args[0]->BooleanValue();
     bool scroll_far = args[1]->BooleanValue();
 
     render_view_impl->BeginSmoothScroll(scroll_down, scroll_far);
     return v8::True();
   }
+
+  static v8::Handle<v8::Value> RunRenderingBenchmarks(
+      const v8::Arguments& args) {
+    // for our name filter, the argument can be undefined or null to run

[nduca, 2012/07/20 20:30:09]

// For

[dmurph, 2012/07/20 20:52:33]

Done.

+    // all benchmarks, or a string for filtering by name
+    if (!args.Length() ||
+        (!args[0]->IsString() &&
+            !(args[0]->IsNull() || args[0]->IsUndefined())))

[piman, 2012/07/20 20:35:35]

nit: indent (! should be aligned with the one above).

[dmurph, 2012/07/20 21:19:13]

Done.

+      return v8::Undefined();
+
+    WebFrame* web_frame = WebFrame::frameForEnteredContext();
+    if (!web_frame)
+      return v8::Undefined();
+
+    WebView* web_view = web_frame->view();
+    if (!web_view)
+      return v8::Undefined();
+
+    v8::Handle<v8::Array> resultsArray = v8::Array::New(0);
+    V8BenchmarkResults results(resultsArray);

[nduca, 2012/07/20 20:30:09]

initialize the results array as late as you can. E.g.

support
benchmarks
results
for loop

[dmurph, 2012/07/20 20:52:33]

Done.

+    std::string name_filter;

[nduca, 2012/07/20 20:30:09]

how about moving the name_filter stuff up to where you're looking at the args
anyway?

[dmurph, 2012/07/20 20:52:33]

Done.

+    if (args[0]->IsNull() || args[0]->IsUndefined()) {
+      name_filter = "";
+    } else {
+      char filter[256];
+      args[0]->ToString()->WriteAscii(filter, 0, sizeof(filter)-1);
+      name_filter = std::string(filter);
+    }
+
+    WebViewBenchmarkSupport* support =
+        web_view->benchmarkSupport();
+    std::vector<RenderingBenchmark*> benchmarks = AllRenderingBenchmarks();
+
+    std::vector<RenderingBenchmark*>::const_iterator it;
+    for (it = benchmarks.begin(); it != benchmarks.end(); it++) {
+      RenderingBenchmark* benchmark = *it;
+      const std::string& name = benchmark->name();
+      if (name_filter != "" &&
+         std::string::npos == name.find(name_filter)) {

[piman, 2012/07/20 20:35:35]

nit: indent (should be +4)

[dmurph, 2012/07/20 21:19:13]

Done.

+        continue;
+      }
+      benchmark->SetUp(support);
+      benchmark->Run(&results, support);
+      benchmark->TearDown(support);
+    }
+
+    return resultsArray;
+  }
 };
 
 v8::Extension* GpuBenchmarkingExtension::Get() {
   return new GpuBenchmarkingWrapper();
 }
 
 }  // namespace content