OLD | NEW |
---|---|
(Empty) | |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_ | |
6 #define CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_ | |
nduca
2012/07/18 06:06:17
Why is all of this public? Its only used by conten
dmurph
2012/07/18 16:31:41
Addessed in other comment
| |
7 | |
8 #include <string> | |
9 | |
10 #include "base/basictypes.h" | |
11 #include "content/common/content_export.h" | |
12 #include "content/public/renderer/rendering_benchmark_results.h" | |
13 #include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSuppo rt.h" | |
nduca
2012/07/18 06:06:17
Dont include until you use.
namespace WebKit {
cla
dmurph
2012/07/18 20:01:57
Done.
| |
14 | |
15 namespace content { | |
16 class CONTENT_EXPORT RenderingBenchmark { | |
nduca
2012/07/18 06:06:17
Dont need CONTENT_EXPORT
dmurph
2012/07/18 20:01:57
Done.
| |
17 public: | |
18 RenderingBenchmark(const std::string& name, | |
19 RenderingBenchmarkResults* results); | |
20 virtual ~RenderingBenchmark(); | |
21 | |
22 virtual void SetUp( | |
23 WebKit::WebViewBenchmarkSupport* benchmarkController) {} | |
nduca
2012/07/18 06:06:17
naming
dmurph
2012/07/18 20:01:57
Done.
| |
24 | |
25 virtual void Run(WebKit::WebViewBenchmarkSupport*) = 0; | |
26 | |
27 virtual void TearDown( | |
28 WebKit::WebViewBenchmarkSupport* benchmarkController) {} | |
29 | |
30 const std::string& name() { return name_; } | |
31 | |
32 protected: | |
33 void RecordResult(const std::string& result_name, | |
nduca
2012/07/18 06:06:17
Why does this have a member variable that is the r
dmurph
2012/07/18 16:31:41
We talked about this earlier, it's to remove the a
dmurph
2012/07/18 20:01:57
Removing :)
| |
34 const std::string& time_unit, | |
35 double time); | |
36 | |
37 private: | |
38 const std::string name_; | |
39 RenderingBenchmarkResults* results_; | |
40 | |
41 DISALLOW_COPY_AND_ASSIGN(RenderingBenchmark); | |
42 }; | |
43 } // namespace content | |
44 #endif // CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_ | |
OLD | NEW |