OLD | NEW |
---|---|
(Empty) | |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_ | |
6 #define CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_ | |
7 | |
8 #include <string> | |
9 | |
10 #include "base/basictypes.h" | |
nduca
2012/07/18 06:06:17
why?
dmurph
2012/07/18 20:01:57
DISALLOW_COPY_AND_ASSIGN, which I'm adding
| |
11 #include "base/compiler_specific.h" | |
nduca
2012/07/18 06:06:17
why?
dmurph
2012/07/18 16:31:41
for OVERRIDE
| |
12 #include "content/common/content_export.h" | |
nduca
2012/07/18 06:06:17
why?
dmurph
2012/07/18 20:01:57
Done.
| |
13 #include "content/public/renderer/rendering_benchmark.h" | |
14 #include "content/public/renderer/rendering_benchmark_results.h" | |
15 #include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSuppo rt.h" | |
16 | |
nduca
2012/07/18 06:06:17
Include only when you need it.
You can predeclare
dmurph
2012/07/18 16:31:41
Yeah, I forgot to clean these up, sorry
| |
17 namespace content { | |
18 class CONTENT_EXPORT AllRenderingBenchmarks : public RenderingBenchmark { | |
nduca
2012/07/18 06:06:17
Why oh why another subclass? Why not just return a
dmurph
2012/07/18 20:01:57
Is it cool if we do getter-style of 'benchmarks()'
| |
19 public: | |
20 AllRenderingBenchmarks(RenderingBenchmarkResults* results, | |
21 const std::string& name_filter); | |
22 virtual ~AllRenderingBenchmarks(); | |
23 | |
24 virtual void Run(WebKit::WebViewBenchmarkSupport*) OVERRIDE; | |
25 | |
26 private: | |
27 const std::string name_filter_; | |
28 RenderingBenchmark** benchmarks_; | |
nduca
2012/07/18 06:06:17
Eep! scoped_vector is your friend. But as I pointe
dmurph
2012/07/18 16:31:41
Yeah I know
| |
29 const int benchmark_count_; | |
nduca
2012/07/18 06:06:17
You're too obsessive about const. Please, save us
dmurph
2012/07/18 20:01:57
Done.
| |
30 }; | |
31 } // namespace content | |
32 | |
33 #endif // CONTENT_PUBLIC_RENDERER_ALL_RENDERING_BENCHMARKS_H_ | |
OLD | NEW |