[Sync] Fix sync scheduler/session logic determining successful commands.

sync/sessions/test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/sessions/test_util.h"
 
 namespace browser_sync {
 namespace sessions {
 namespace test_util {
 
@@ skipping 20 matching lines @@
   session->mutable_status_controller()->set_last_download_updates_result(
       NETWORK_CONNECTION_UNAVAILABLE);
 }
 
 void SimulateSuccess(sessions::SyncSession* session,
                      SyncerStep begin, SyncerStep end) {
   if (session->HasMoreToSync()) {
     ADD_FAILURE() << "Shouldn't have more to sync";
   }
   ASSERT_EQ(0U, session->status_controller().num_server_changes_remaining());
+  session->SetFinished();
+  if (end == SYNCER_END) {
+    session->mutable_status_controller()->set_last_download_updates_result(
+        SYNCER_OK);
+    session->mutable_status_controller()->set_last_post_commit_result(
+        SYNCER_OK);
+    session->mutable_status_controller()->
+        set_last_process_commit_response_result(SYNCER_OK);
+  }
 }
 
 void SimulateThrottledImpl(sessions::SyncSession* session,
     const base::TimeDelta& delta) {
   session->delegate()->OnSilencedUntil(base::TimeTicks::Now() + delta);
 }
 
 void SimulatePollIntervalUpdateImpl(sessions::SyncSession* session,
     const base::TimeDelta& new_poll) {
   session->delegate()->OnReceivedLongPollIntervalUpdate(new_poll);
 }
 
 void SimulateSessionsCommitDelayUpdateImpl(sessions::SyncSession* session,
     const base::TimeDelta& new_delay) {
   session->delegate()->OnReceivedSessionsCommitDelay(new_delay);
 }
 
 }  // namespace test_util
 }  // namespace sessions
 }  // namespace browser_sync