Prototype re-compiling methods in dart2js

lib/compiler/implementation/enqueue.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class EnqueueTask extends CompilerTask {
   final Enqueuer codegen;
   final Enqueuer resolution;
 
   String get name() => 'Enqueue';
 
   EnqueueTask(Compiler compiler)
     : codegen = new Enqueuer(compiler),
       resolution = new Enqueuer(compiler),
       super(compiler) {
     codegen.task = this;
     resolution.task = this;
   }
 }
 
+class RecompilationQueue {
+  final Queue<WorkItem> queue;
+  final Set<Element> queueElements;
+
+  RecompilationQueue()
+    : queue = new Queue<WorkItem>(),
+      queueElements = new Set<Element>();
+
+  void add(Element element, [TreeElements elements]) {

[floitsch, 2012/06/07 10:59:39]

not that it matters, but afaics the second argument doesn't need to be optional.

[Søren Gjesse, 2012/06/13 10:55:09]

Done.

+    if (queueElements.contains(element)) return;
+    if (element.kind !== ElementKind.GENERATIVE_CONSTRUCTOR_BODY &&

[floitsch, 2012/06/07 10:59:39]

Explain why these are not recompilation canditates.

[Søren Gjesse, 2012/06/13 10:55:09]

Turned out that it is only for generative constructors, not generative
constructor bodies. Not sure why exactly - added a TODO.

+        element.kind !== ElementKind.GENERATIVE_CONSTRUCTOR) {
+      queueElements.add(element);
+      queue.add(new WorkItem(element, elements));
+    }
+  }
+
+  int get length() => queue.length;
+
+  bool isEmpty() => queue.isEmpty();
+
+  WorkItem next() {
+    WorkItem item = queue.removeLast();
+    queueElements.remove(item.element);
+    return item;
+  }
+}
+
 class Enqueuer {
   final Compiler compiler; // TODO(ahe): Remove this dependency.
   final Map<String, Link<Element>> instanceMembersByName;
   final Set<ClassElement> seenClasses;
   final Universe universe;
   final Queue<WorkItem> queue;
+  final RecompilationQueue recompilationCandidates;
   bool queueIsClosed = false;
   EnqueueTask task;
 
   Enqueuer(this.compiler)
     : instanceMembersByName = new Map<String, Link<Element>>(),
       seenClasses = new Set<ClassElement>(),
       universe = new Universe(),
-      queue = new Queue<WorkItem>();
+      queue = new Queue<WorkItem>(),
+      recompilationCandidates = new RecompilationQueue();
 
   void addToWorkList(Element element, [TreeElements elements]) {
+    if (compiler.pass == 2) return;

[floitsch, 2012/06/07 10:59:39]

assert that the element has already been compiled?

[Søren Gjesse, 2012/06/13 10:55:09]

Done.

     if (queueIsClosed) {
       compiler.internalErrorOnElement(element, "Work list is closed.");
     }
     if (element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
       registerInstantiatedClass(element.enclosingElement);
     }
     queue.add(new WorkItem(element, elements));
   }
 
+  void addToRecompilationCandidates(Element element, [TreeElements elements]) {
+    if (queueIsClosed) {
+      compiler.internalErrorOnElement(element, "Work list is closed.");
+    }
+    recompilationCandidates.add(element, elements);
+  }
+
   void registerInstantiatedClass(ClassElement cls) {
     universe.instantiatedClasses.add(cls);
     onRegisterInstantiatedClass(cls);
   }
 
   bool checkNoEnqueuedInvokedInstanceMethods() {
     task.measure(() {
       // Run through the classes and see if we need to compile methods.
       for (ClassElement classElement in universe.instantiatedClasses) {
         for (ClassElement currentClass = classElement;
@@ skipping 166 matching lines @@
 
   void registerDynamicSetter(SourceString methodName, Selector selector) {
     registerSetter(methodName, selector);
   }
 
   // TODO(ngeoffray): This should get a type.
   void registerIsCheck(Element element) {
     universe.isChecks.add(element);
   }
 }