chrome/common/extensions/api/experimental_socket.idl - Issue 10537017: Allow hostnames in socket.connect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/experimental_socket.idl

Issue 10537017: Allow hostnames in socket.connect(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mihaip's comments + clang fix. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/experimental_socket.idl

diff --git a/chrome/common/extensions/api/experimental_socket.idl b/chrome/common/extensions/api/experimental_socket.idl

index 785e7d2482ba384631d228dab720ff25a5650427..2e1cdc09e471f5732f9513f3a6d599d47c2fb68d 100644

--- a/chrome/common/extensions/api/experimental_socket.idl

+++ b/chrome/common/extensions/api/experimental_socket.idl

@@ -78,11 +78,11 @@

// Connects the socket to the remote machine.

// |socketId| : The socketId.

- // |address| : The address of the remote machine.

+ // |hostname| : The hostname or IP address of the remote machine.

// |port| : The port of the remote machine.

// |callback| : Called when the connection attempt is complete.

static void connect(long socketId,

- DOMString address,

+ DOMString hostname,

long port,

ConnectCallback callback);

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/data/extensions/api_test/dns/api/background.js » ('j') | no next file with comments »