compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 10537006: Issue 3266. Produce a warning when trying to call an inaccessible method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10537006: Issue 3266. Produce a warning when trying to call an inaccessible method (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 052c1158fc67598904fb4548cfe8275bb849a677..a7493a34ecaa3a44a1257961a0f3dda33fdb8fa9 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -1185,6 +1185,10 @@ public class Resolver {

if (member != null) {

if (!member.getElement().getModifiers().isStatic()) {

element = member.getElement();

+ // Must be accessible.

+ if (!Elements.isAccessible(context.getScope().getLibrary(), element)) {

+ onError(x, ResolverErrorCode.CANNOT_ACCESS_METHOD, x.getFunctionNameString());

+ }

}

break;

@@ -1454,6 +1458,9 @@ public class Resolver {

if (isStaticContextOrInitializer()) {

onError(node, ResolverErrorCode.CANNOT_RESOLVE_METHOD, name);

}

+ if (scope.findElement(null, name) != null) {

+ onError(node, ResolverErrorCode.CANNOT_ACCESS_METHOD, name);

+ }

break;

case CONSTRUCTOR: