Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 10536232: Use nv contrl x extension to query nvidia driver version. (Closed)

Created:
8 years, 6 months ago by Zhenyao Mo
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Use nv contrl x extension to query nvidia driver version. So we can do it in browser process, not wait until gpu process launches and a gl context is created. This is tested on my linux box with NVIDIA driver. We need to put more code to tell chrome (Linux/NVIDIA) that we have enough information for blacklisting, so at GPU launch time we don't need to collect GPUInfo. Will do it in a followup CL. BUG=122912 TEST=tree green TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143323

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M content/content_gpu.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 1 4 chunks +49 lines, -6 lines 0 comments Download
A third_party/libXNVCtrl/libXNVCtrl.gyp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhenyao Mo
This CL depends on the landing of libXNVCtrl (http://codereview.chromium.org/10578052/), but it can be reviewed without ...
8 years, 6 months ago (2012-06-20 23:44:52 UTC) #1
piman
LGTM + nit https://chromiumcodereview.appspot.com/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc File content/gpu/gpu_info_collector_linux.cc (right): https://chromiumcodereview.appspot.com/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc#newcode179 content/gpu/gpu_info_collector_linux.cc:179: int event_base, error_base; nit: =0
8 years, 6 months ago (2012-06-21 00:08:32 UTC) #2
Ken Russell (switch to Gerrit)
LGTM too https://chromiumcodereview.appspot.com/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc File content/gpu/gpu_info_collector_linux.cc (right): https://chromiumcodereview.appspot.com/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc#newcode174 content/gpu/gpu_info_collector_linux.cc:174: Display* display = base::MessagePumpForUI::GetDefaultXDisplay(); Please make sure ...
8 years, 6 months ago (2012-06-21 00:30:54 UTC) #3
Zhenyao Mo
http://codereview.chromium.org/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc File content/gpu/gpu_info_collector_linux.cc (right): http://codereview.chromium.org/10536232/diff/3001/content/gpu/gpu_info_collector_linux.cc#newcode174 content/gpu/gpu_info_collector_linux.cc:174: Display* display = base::MessagePumpForUI::GetDefaultXDisplay(); On 2012/06/21 00:30:54, kbr wrote: ...
8 years, 6 months ago (2012-06-21 00:45:43 UTC) #4
jam
8 years, 6 months ago (2012-06-21 02:48:14 UTC) #5
please don't commit without running a try run or CQ. This change broke the tree.

Powered by Google App Engine
This is Rietveld 408576698