Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10536221: Merge 120750 - Fix scrollbar layers being misplaced with a clipped owner layer (Closed)

Created:
8 years, 6 months ago by enne (OOO)
Modified:
8 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120750 - Fix scrollbar layers being misplaced with a clipped owner layer https://bugs.webkit.org/show_bug.cgi?id=89486 Reviewed by Simon Fraser. Source/WebCore: Scrollbar layers are positioned relative to their parent layer. If that parent gets clipped, then that positioning becomes incorrect and scrollbars get positioned relative to the clipped bounds instead of the full bounds. Fix by not clipping in this case. Test: compositing/overflow/scrollbars-with-clipped-owner.html * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::shouldClipCompositedBounds): LayoutTests: * compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added. * compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added. * compositing/overflow/scrollbars-with-clipped-owner.html: Added. TBR=enne@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --3 lines) Patch
A + LayoutTests/compositing/overflow/scrollbars-with-clipped-owner.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/overflow/scrollbars-with-clipped-owner-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/overflow/scrollbars-with-clipped-owner-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerBacking.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
enne (OOO)
8 years, 6 months ago (2012-06-20 18:36:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698