Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 10536207: Remove layoutTestController from test_shell. (Closed)

Created:
8 years, 6 months ago by tony
Modified:
8 years, 6 months ago
Reviewers:
tkent, jamesr, dglazkov
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove layoutTestController from test_shell. webkit/glue/iframe_redirect_unittest.cc was moved to webkit_unit_tests in WebKit r120391, so we can delete it. Nothing else depends on layoutTestController, so we can remove it. There's still a bunch of layout testing code in test_shell. I'll remove those in follow up changes. BUG=132672 TEST=Covered by test_shell_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143661

Patch Set 1 #

Patch Set 2 : remove unit test file #

Patch Set 3 : comment cleanup #

Patch Set 4 : mac fix #

Patch Set 5 : mac fix 2 #

Patch Set 6 : really fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -564 lines) Patch
D webkit/data/test_shell/iframe_redirect/child.html View 1 chunk +0 lines, -8 lines 0 comments Download
D webkit/data/test_shell/iframe_redirect/main.html View 1 chunk +0 lines, -12 lines 0 comments Download
D webkit/glue/iframe_redirect_unittest.cc View 1 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/tools/test_shell/layout_test_controller.h View 1 chunk +0 lines, -145 lines 0 comments Download
D webkit/tools/test_shell/layout_test_controller.cc View 1 chunk +0 lines, -287 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 2 3 7 chunks +9 lines, -22 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 4 chunks +1 line, -11 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_mac.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 4 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tony
8 years, 6 months ago (2012-06-19 18:58:54 UTC) #1
tony
+ more reviewers
8 years, 6 months ago (2012-06-21 19:20:34 UTC) #2
jamesr
sorry this fell off my radar LGTM
8 years, 6 months ago (2012-06-21 19:23:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10536207/14
8 years, 6 months ago (2012-06-21 19:31:34 UTC) #4
commit-bot: I haz the power
Try job failure for 10536207-14 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-21 19:46:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10536207/15002
8 years, 6 months ago (2012-06-21 22:16:32 UTC) #6
commit-bot: I haz the power
Try job failure for 10536207-15002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-21 23:24:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10536207/15002
8 years, 6 months ago (2012-06-22 17:22:35 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 19:04:18 UTC) #9
Change committed as 143661

Powered by Google App Engine
This is Rietveld 408576698