Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/d8.cc

Issue 10536202: Fix a bunch of implicit casts detected by the Win64 compiler (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/debug.cc » ('j') | src/factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 7a01d55148fa768c0eaba8a5a472f3513ef46d6b..600d5131f47152c6c737d560d1b1f15abe3af919 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -284,7 +284,7 @@ Handle<Value> Shell::Load(const Arguments& args) {
return Undefined();
}
-static size_t convertToUint(Local<Value> value_in, TryCatch* try_catch) {
+static int32_t convertToUint(Local<Value> value_in, TryCatch* try_catch) {
if (value_in->IsUint32()) {
return value_in->Uint32Value();
rossberg 2012/06/19 13:35:30 You probably need a static_cast here now, because
Jakob Kummerow 2012/06/19 13:44:08 Done.
}
@@ -312,7 +312,7 @@ static size_t convertToUint(Local<Value> value_in, TryCatch* try_catch) {
ThrowException(
String::New("Array length exceeds maximum length."));
}
- return static_cast<size_t>(raw_value);
+ return static_cast<int32_t>(raw_value);
rossberg 2012/06/19 13:35:30 You can remove this cast altogether.
Jakob Kummerow 2012/06/19 13:44:08 Done.
}
« no previous file with comments | « src/assembler.cc ('k') | src/debug.cc » ('j') | src/factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698