Issue 10536199: test-api.cc assertion failure due to call Heap::CollectAllGarbage(true)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536199: test-api.cc assertion failure due to call Heap::CollectAllGarbage(true) (Closed)

Created:
8 years, 6 months ago by Zheng Liu

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium), ulan

CC:
v8-dev, zheng.z.liu

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

In test-api.cc a few calls to Heap::CollectAllGarbage use obsolete argument. The assertion failure I ran into is in Regress1516, where collector falls back to SCAVENGER, during x64.debug.check run. Zheng Liu zheng.z.liu@intel.com Committed: https://code.google.com/p/v8/source/detail?r=11889

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	test/cctest/test-api.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for the patch. I will land it for you.

Expand Messages | Collapse Messages