Issue 10536170: Add missing string length check in regexp engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536170: Add missing string length check in regexp engine. (Closed)

Created:
8 years, 6 months ago by Yang

Modified:
8 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add missing string length check in regexp engine. R=erik.corry@gmail.com BUG=v8:2172 TEST=regress-2172.js Committed: https://code.google.com/p/v8/source/detail?r=11816

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
M	src/ia32/regexp-macro-assembler-ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2172.js	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

8 years, 6 months ago (2012-06-14 13:52:39 UTC) #2

lgtm

http://codereview.chromium.org/10536170/diff/1/test/mjsunit/regress/regress-2...
File test/mjsunit/regress/regress-2172.js (right):

http://codereview.chromium.org/10536170/diff/1/test/mjsunit/regress/regress-2...
test/mjsunit/regress/regress-2172.js:29: (i + "\0").split(/(.)\1/i);
Please also test the UTF-16 case.

Expand Messages | Collapse Messages