Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10536165: Fix STEP_WARNINGS for android buildbot (Closed)

Created:
8 years, 6 months ago by Isaac (away)
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski, bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Fix STEP_WARNINGS for android buildbot - bb_goma_make does not return the exit status of make due to the goma shutdown step. For bb_compile_experimental, bash exit on error is disabled and we are relying on bb_goma_make exit status to determine failure. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/buildbot_functions.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
Locally tested http://levy.mtv:8011/builders/Chromium%20Linux%20Android%20Builder/builds/19
8 years, 6 months ago (2012-06-14 07:41:26 UTC) #1
Isaac (away)
Copy and paste the link instead of clicking
8 years, 6 months ago (2012-06-14 07:42:53 UTC) #2
bulach
lgtm, thanks!
8 years, 6 months ago (2012-06-14 07:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10536165/1
8 years, 6 months ago (2012-06-14 07:46:52 UTC) #4
commit-bot: I haz the power
Change committed as 142111
8 years, 6 months ago (2012-06-14 08:48:59 UTC) #5
John Grabowski
8 years, 6 months ago (2012-06-14 18:27:51 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698